519669 - Thread summary head panel buttons fire their actions when right-clicking on them.

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Valery Kondakoff]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.4pre) Gecko/20090929 Shredder/3.0pre

There are two buttons in my thread summary head panel: Archive and Delete. Both of them fire their actions when user left-click on them. This is pretty normal. But they are firing the actions when user right-click on them as well.

This seems dangerous comparing with the behavior of the buttons in the message view header pane, where right-click fires the customization pop-up. 

Reproducible: Always

Comment 1

[[:Aureliano Buendía]]

Confirmed also here on 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090929 Lightning/1.0pre Shredder/3.0pre ID:20090929031525

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

we need this fixed for release considering right clicking on the message reader header buttons changes their mode, these buttons should at least ignore the right click.

Comment 3

[David Ascher (:davida)]

Attachment: simple fix

Simple fix. I don't believe this needs ui-review, given the clarity of the spec. But if bryan wants to jump in anyway, fine w/ me.

Comment 4

[Mark Banner (:standard8)]

Attachment: simple fix v2

Same patch with the return statements dropped - we were getting warnings about not always returning a value. As the functions called don't return a value anyway, then there is no point in trying to return one.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/baaa7f29d53b