Drag selecting listbox doesn't scroll listbox anymore

RESOLVED FIXED

Status

()

Core
Event Handling
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Neil Deakin (away until Feb 4))

Tracking

({regression, testcase})

Trunk
x86
Windows XP
regression, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Not sure when this regressed, but drag-selecting a listbox (multiple select) with the mouse doesn't scroll the listbox anymore.
(Reporter)

Comment 1

8 years ago
Created attachment 403766 [details]
testcase

Just a guess, perhaps a regression from bug 517787?
this regressed within
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f2a06414948c&tochange=97d2891732b4

=> Bug 507592 (blocking1.9.2+ yet not landed on 192) and/or Bug 516615
Keywords: regressionwindow-wanted
(Assignee)

Updated

8 years ago
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Depends on: 516615
(Assignee)

Comment 3

8 years ago
Created attachment 405293 [details] [diff] [review]
fix

Simple fix which is to restore the check for scrollable frames.
Attachment #405293 - Flags: review?(roc)
Comment on attachment 405293 [details] [diff] [review]
fix

What we really should do here is use nsIScrollableViewProvider, except that sucks and I've got patches that replace it with a method nsIFrame::GetScrollableFrame(), so I should just replace this patch with that method in my patches
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/7a931f8811fa
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.