Status

defect
P1
normal
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: clouserw, Assigned: jbalogh)

Tracking

unspecified
Dependency tree / graph

Details

()

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

10 years ago
This is 1.2 in the spec - your favorite page, a modified themes page! Mockup available in attachment 394072 [details].  The categories should use the existing categories on http://www.getpersonas.com/en-US/gallery/All/Popular
Reporter

Updated

10 years ago
Priority: -- → P1
Blocks: 519862
Assignee

Comment 1

10 years ago
Posted patch personas list view (obsolete) — Splinter Review
no personas onhover js, that comes later
Attachment #405510 - Flags: review?(clouserw)
Assignee

Comment 2

10 years ago
Posted patch personas list view (obsolete) — Splinter Review
with all the goodies this time
Attachment #405519 - Flags: review?(clouserw)
Assignee

Updated

10 years ago
Attachment #405510 - Attachment is obsolete: true
Attachment #405510 - Flags: review?(clouserw)
Assignee

Comment 3

10 years ago
rdoherty pointed out that I have too much nesting
Attachment #405535 - Flags: review?
Assignee

Updated

10 years ago
Attachment #405519 - Attachment is obsolete: true
Attachment #405519 - Flags: review?(clouserw)
Assignee

Updated

10 years ago
Attachment #405535 - Flags: review? → review?(fwenzel)
Comment on attachment 405535 [details] [diff] [review]
personas list view

I tried it out and it works very well. There's a huge amount of personas, wow.

Also thanks for cleaning up trailing whitespace (I try to do that too) but patches are easier to read if you exclude those lines, then sneak them in when you commit :)
Attachment #405535 - Flags: review?(fwenzel) → review+
Assignee

Comment 5

10 years ago
Thanks! r53162

QA: note that /persona/<id> detail pages are bug 519865, which is still open at the moment.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Verified FIXED; we've been testing (and filing one-off bugs for this).
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.