Closed
Bug 519859
Opened 15 years ago
Closed 15 years ago
Add "Browse Personas" page
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P1)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.2
People
(Reporter: clouserw, Assigned: jbalogh)
References
()
Details
Attachments
(1 file, 2 obsolete files)
30.68 KB,
patch
|
wenzel
:
review+
|
Details | Diff | Splinter Review |
This is 1.2 in the spec - your favorite page, a modified themes page! Mockup available in attachment 394072 [details]. The categories should use the existing categories on http://www.getpersonas.com/en-US/gallery/All/Popular
Reporter | ||
Updated•15 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•15 years ago
|
||
no personas onhover js, that comes later
Attachment #405510 -
Flags: review?(clouserw)
Assignee | ||
Comment 2•15 years ago
|
||
with all the goodies this time
Attachment #405519 -
Flags: review?(clouserw)
Assignee | ||
Updated•15 years ago
|
Attachment #405510 -
Attachment is obsolete: true
Attachment #405510 -
Flags: review?(clouserw)
Assignee | ||
Comment 3•15 years ago
|
||
rdoherty pointed out that I have too much nesting
Attachment #405535 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Attachment #405519 -
Attachment is obsolete: true
Attachment #405519 -
Flags: review?(clouserw)
Assignee | ||
Updated•15 years ago
|
Attachment #405535 -
Flags: review? → review?(fwenzel)
Comment 4•15 years ago
|
||
Comment on attachment 405535 [details] [diff] [review] personas list view I tried it out and it works very well. There's a huge amount of personas, wow. Also thanks for cleaning up trailing whitespace (I try to do that too) but patches are easier to read if you exclude those lines, then sneak them in when you commit :)
Attachment #405535 -
Flags: review?(fwenzel) → review+
Assignee | ||
Comment 5•15 years ago
|
||
Thanks! r53162 QA: note that /persona/<id> detail pages are bug 519865, which is still open at the moment.
Comment 6•15 years ago
|
||
QA testable here: https://preview.addons.mozilla.org/en-US/firefox/personas/
Comment 7•15 years ago
|
||
Verified FIXED; we've been testing (and filing one-off bugs for this).
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Keywords: push-needed
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•