Closed
Bug 519865
Opened 15 years ago
Closed 15 years ago
Add Personas detail page
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P1)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.2
People
(Reporter: clouserw, Assigned: jbalogh)
References
()
Details
Attachments
(1 file)
15.42 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
This is 1.7 in the spec: The persona listing pages will be hosted on AMO and contain the same data as the 'details' page on getpersonas.com. The actual personas and images will be served off of getpersonas.com. If a user doesn't have the personas add-on installed, it will be installed when the user clicks 'get persona'. User names will be linked to user profiles on getpersonas.com. There should also be 'learn more about personas' links that point to getpersonas.com. This is similar in principle to non-hosted add-ons on AMO (which we've been wanting to do for a while).
rdoherty is rewriting the download buttons in this release so please coordinate with him since this will affect those.
Reporter | ||
Updated•15 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•15 years ago
|
||
Are we going to do the hover trick on AMO? Is there anything special I need to know to do that?
Summary: Add Persona listings page → Add Personas detail page
Reporter | ||
Comment 2•15 years ago
|
||
It's JS as far as I know. We should be able to steal it from getpersonas.c
Comment 3•15 years ago
|
||
There's a JSON blob on the element that contains the persona info. Any page with a persona image will have it there.
persona="{"id":"33","name":"Groovy Blue","accentcolor":"#6699ff","textcolor":"#07188d","header":"3\/3\/33\/tbox-groovy_blue.jpg","footer":"3\/3\/33\/stbar-groovy_blue.jpg","category":"Abstract","description":null,"author":"Lee.Tom","detailURL":"http:\/\/www.getpersonas.com\/persona\/33","headerURL":"http:\/\/www.getpersonas.com\/static\/3\/3\/33\/tbox-groovy_blue.jpg","footerURL":"http:\/\/www.getpersonas.com\/static\/3\/3\/33\/stbar-groovy_blue.jpg","previewURL":"http:\/\/www.getpersonas.com\/static\/3\/3\/33\/preview.jpg","iconURL":"http:\/\/www.getpersonas.com\/static\/3\/3\/33\/preview_small.jpg"}"
JS is here, which contains personas add-on detection and events for previewing/loading personas.
http://viewvc.svn.mozilla.org/vc/projects/getpersonas.com/trunk/static/js/script.js?revision=52457&view=markup
JS fires events on that element which the Personas add-on or 3.6 catches and loads the image.
We will be moving images to a CDN so be prepared for the image urls to change.
Assignee | ||
Comment 4•15 years ago
|
||
Attachment #405944 -
Flags: review?(clouserw)
Reporter | ||
Updated•15 years ago
|
Attachment #405944 -
Flags: review?(clouserw) → review+
Assignee | ||
Comment 6•15 years ago
|
||
QA: Note that if you don't have preview.amo in your list of security-excepted sites, you won't be able to preview or install personas.
Comment 7•15 years ago
|
||
According to the description, https://bugzilla.mozilla.org/show_bug.cgi?id=519865#c0 there should be a 'learn more about personas' link. This link is missing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•15 years ago
|
||
also filed Bug 522407 related to personas detail page.
Assignee | ||
Comment 9•15 years ago
|
||
Added "What are Personas?" in r53475. Flig/nick/anyone, what's a better place for the link than it's current spot? I just dropped it in so Wil could push 110n.
Assignee | ||
Comment 10•15 years ago
|
||
styled in r53595.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 11•15 years ago
|
||
I think the link is fine where it is- let's just leave it there!
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/persona/15232.
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Keywords: push-needed
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•