519922 - Every typing in text field beeps with Japanese IME turned on

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Eiichi]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en; rv:1.9.0.15pre) Gecko/2009093000 Camino/2.0b5pre (like Firefox/3.0.15pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en; rv:1.9.0.15pre) Gecko/2009093000 Camino/2.0b5pre (like Firefox/3.0.15pre)

Every typing beeps with Japanese IME turned on in text field.
This problem happens on 2009-09-30-00-2.0-M1.9.
No problem on 2009-09-29-00-2.0-M1.9.
So related check-in an attachment 403544 [details] [diff] [review] of bug 379199 ?


Reproducible: Always

Steps to Reproduce:
1. Set Japanese IME on.
2. Go to http://www.google.co.jp/
3. Type "nihongo" in search field.

Comment 1

[Eiichi]

I backed out an attachment 403544 [details] [diff] [review] of bug 379199 and made a test build.
The test build has no problem, so I think this bug is attributed to an attachment 403544 [details] [diff] [review] of bug 379199 .

Comment 2

[philippe (part-time)]

This is not limited to Japanese Input.
Typing composite characters (é, è, ü, î, etc) also beep.

Comment 3

[Stuart Morgan]

Attachment: fix

Luckily, we had a contingency plan in place in case of unexpected regressions like this: black-hole everything ourselves ;)

This fixes this bug, as well as fixing delete-as-back (bug 379812) and esc-as-stop handling (bug 405748). (The latter doesn't work with text fields and plugins focused, which may not have been the case back in 1.6, but it's the safer approach as esc has an IME meaning as well).

Comment 4

[Eiichi]

Thanks, Stuart.
I applied the patch and made a test build.
The patch works fine as expected for this bug, bug 379812 and bug 405748.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 404042 [details] [diff] [review]
fix

sr=pink

Comment 6

[Stuart Morgan]

Landed on CVS trunk and CAMINO_2_0_BRANCH.

Comment 8

[philippe (part-time)]

Verified with 2.1a1pre (1.9.0.16pre 2009100901)