51996 - selecting a theme from the Apply Theme menu doesn't call DismissChain()

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[:deanis74]

(from bug 38425)

[Blake Ross]
I notice also that using the View | Apply Theme menu to dynamically change 
themes doesn't clear the selected theme item in that menu (when you reopen the 
submenu, the item is still selected, same problem as this bug reports).  
Probably related.

[Dean Tessman] 
Nope, my patch doesn't affect this.  I think this is a different problem.  Using 
the new Modern skin, I see that after selecting a theme from the Apply Theme 
menu, the View menu on the menubar is still depressed on mouseover.  Did that 
make sense?  Maybe not.  Try these steps:

1. Open the View > Apply Theme menu.
2. Select Modern
3. Mouse over the top-level menu items in the menu bar.

"View" is depressed while all the other items look normal.  Almost like 
something isn't processing through to completion.

----

This then disables use of the keyboard for selecting menu items.

The problem seems to be that this "if" statement is failing, although why I'm 
not yet sure:

http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsMenuFrame.cpp#1505

Because this fails, DismissChain() is never called, and that's probably causing 
the behavior we're seeing.

Build: Sept 8 2000 (don't have an exact id handy)

(guessing that Platform and OS are all)

Comment 1

[:deanis74]

cc'ing Blake

Comment 2

[:deanis74]

I think that it may be related to the rdf datasource that is used to fill the 
list of themes, but I don't know where to start looking at that stuff.

Comment 3

[:deanis74]

The themes in the Apply Theme menu call nsChromeRegistry::SelectSkin(), but 
after that it's for someone else to figure out.

This probably needs to be reassigned, but I'm not sure to whom.

And I wouldn't call this trivial behavior, as I see a lot of people using this 
menu.

Comment 4

[:deanis74]

Found this comment:

http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsMenuBarFrame.cpp#9
8

Wonder if the tearing down of frames that it mentions has something to do with 
this bug.

Comment 5

[Mike Pinkerton (not reading bugmail)]

cosmetic, non-grandma-killing --> future

Comment 6

[:deanis74]

But really ugly, especially for a menu that will probably be used a fair bit.

Comment 7

[:deanis74]

Also, if I recall correctly, shortcut keys (eg. Ctrl+N) don't work after 
selecting one of these menu items.

Comment 8

[Blake Ross]

*** Bug 54575 has been marked as a duplicate of this bug. ***

Comment 9

[Blake Ross]

hmm...in my new build this works now!  can anyone confirm this?

Comment 10

[:deanis74]

Blake, I pulled an M18 nightly from today (2000100908) and it's still not 
working.

Comment 11

[:deanis74]

*** Bug 60815 has been marked as a duplicate of this bug. ***

Comment 12

[Blake Ross]

still working for me...

Comment 13

[:deanis74]

Still seeing this.  Using today's build, if I follow my steps as originally 
described, the View item on the menu bar is depressed / "active" and shortcut 
keys (eg. Ctrl+F) no longer work.

Comment 14

[:deanis74]

*** Bug 65240 has been marked as a duplicate of this bug. ***

Comment 15

[Jesse Ruderman]

In 0202 Win98, I can't open the View menu at all after switching themes.  (This 
is a regression since 0201.)  Should I file a new bug or raise this one's 
severity?

Comment 16

[Jesse Ruderman]

After switching themes, I can't open the Edit menu either (!).  All menus other 
than Edit and View work fine.

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

I've got a similar problem:
After I change the theme, I can't select some Menus (Edit, View, Search, Go,
Bookmarks); but only in the window I changed the theme in.

Newly opened windows work fine.

Comment 18

[:deanis74]

Hyatt has a fix for the other menu problems over in bug 67574.

Comment 19

[:deanis74]

Hmmmm.... cc: Hyatt.

Comment 20

[:deanis74]

Hyatt, just to double-check my assumption from way back, DismissChain() _should_ 
get called after Execute() for any menu item, right?

Mike, mind if I take this one?

Comment 21

[:deanis74]

*** Bug 76635 has been marked as a duplicate of this bug. ***

Comment 22

[Diego Biurrun]

Parts of this may have regressed. See bug 83325 and bug 81096 which describe
problems with the View menu disappearing after switching themes.

Comment 23

[Manoj]

the apply theme buttons are still not aligned correctly in Build 2001060703.
also, when changing from classic to modern, clicking the Ok button does not
close the
preferences dialog. Instead, one has to click Cancel for the preferences dialog
to disappear.

Comment 24

[Mike Pinkerton (not reading bugmail)]

new owner

Comment 25

[:deanis74]

I don't see this in recent builds, since dynamic skin switching was re-enabled.
 Works for me, 2002010703 on Win2K.