window.openDialog features should apply consistently between platforms (resizable is true by default on mac)

NEW
Unassigned

Status

()

Core
XUL
9 years ago
4 years ago

People

(Reporter: Magnus Melin, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
+++ This bug was initially created as a clone of Bug #507392 +++

As noted in Bug #507392 passing window.openDialog "titlebar" and "resizable=no" both make modal dialogs not resizable on the mac. (But resizable=no is not applicable to modal dialogs on windows and linux.)

In Bug #507392 comment #22 neil writes:

"OK, so I've trawled through window watcher, app shell and widget, and what
happens if you have a dialog but fail to specify (either positively or
negatively) any of the chrome features (including titlebar or close, which
default to on, and can therefore be safely used to disable this behaviour),
then you get a widget-defined set of default flags. And in Windows widget
that's no features, while in Mac widget that's all features. (I'm not sure
about GTK2; it passes -1 which may not even be valid?)"
(In reply to comment #0)
> then you get a widget-defined set of default flags.

Is that when eBorderStyle_default is set?

> And in Windows widget
> that's no features, while in Mac widget that's all features. (I'm not sure
> about GTK2; it passes -1 which may not even be valid?)"

What do you think would be the "correct" behaviour? "Behave like Windows"?

Comment 2

9 years ago
(In reply to comment #1)
> (In reply to comment #0)
> > then you get a widget-defined set of default flags.
> Is that when eBorderStyle_default is set?
Right.

> > And in Windows widget
> > that's no features, while in Mac widget that's all features. (I'm not sure
> > about GTK2; it passes -1 which may not even be valid?)"
> What do you think would be the "correct" behaviour? "Behave like Windows"?
Generally we either want to open windows, which use "all,dialog=no", or dialogs, which use "modal" (both chrome and dialog are implied). Due to this "bug" though, "modal" actually results in platform-specific behaviour. It seems odd to have to specify "modal,close" or "modal,resizable=no" when "close" and "resizable=no" are the default as long as the other is specified, so my preference would be for "modal" to open the most appropriate styles for a dialog, which is in fact what currently happens on Windows, but only by chance. Maybe we should rename eBorderStyle_default to eBorderStyle_dialog?
You need to log in before you can comment on or make changes to this bug.