520037 - heapSpace array should have correct alignment for GCHeap structure

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

Description

[Chris Dearman]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.14) Gecko/2009090217 Ubuntu/9.04 (jaunty) Firefox/3.0.14
Build Identifier: 

GCHeap::Init instantiates a GCHeap object using the heapSpace array.
GCHeap needs to be 8 byte aligned on some platforms (it contains double data)
The heapSpace array is defined as a uint8_t array which won't necessarily have the correct alignment


Reproducible: Always

Comment 1

[Chris Dearman]

Attachment: Possible fix for heapSpace alignment issues

A workaround patch to fix the heapSpace alignment problem

It's not ideal because it replicates macros that already exist in vprof/vprof.h. I don't know the acceptable attribute/declspec values for non-GCC compilers so I have just left them as is.

I think it would be useful to have a global set of macros to deal with alignment issues

Comment 2

[Lars T Hansen]

Attachment: Reworked patch

Lifts AVMPLUS_ALIGN16 into platform header files; adds AVMPLUS_ALIGN8; uses the latter to fix the heapSpace alignment.

Comment 3

[Lars T Hansen]

redux changeset:   2666:aca9df4b22c6