If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"Learn More" link for Mac DivX player goes to Windows-specific page

VERIFIED FIXED

Status

addons.mozilla.org Graveyard
Policy
--
major
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: stephend, Unassigned)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
STR:

1. Load https://www-trunk.stage.mozilla.com/en-US/plugincheck/ using Firefox 3.5.3 with:

DivX Web Player

File name: DivXBrowserPlugin.plugin
DivX Web Player version 1.4.1.4
2. Click on the green "Learn More" button

Expected:

Taken to http://www.divx.com/en/products/software/mac/divx

Actual:

Taken to http://www.divx.com/en/web-player-windows

Comment 1

8 years ago
Created attachment 404120 [details] [diff] [review]
Adding url to each release mac win

This patch adds to releases mac and win and a url for each.

I'm not sure if I can use "url" in the release object or if I should use "manual_installation_url" or something else.
Attachment #404120 - Flags: review?(lorchard)
Comment on attachment 404120 [details] [diff] [review]
Adding url to each release mac win

Looks fine to me.  Basically, I have this in the wiki docs:

url 
    URL with details describing the plugin 
manual_installation_url 
    URL for a manually-launched executable installer for the plugin
My understanding from feedback so far is that if you have a direct download URL to an .exe /.dmg/etc, that's "manual_installation_url".  

But, it's "url" if it's a details page for a human to take further action before installing (eg. finding the download link, registering, etc).

Also, any of those properties listed on the wiki page can be used in either the meta or individual releases.  The meta establishes defaults that each release can override.
Attachment #404120 - Flags: review?(lorchard) → review+

Comment 3

8 years ago
I don't see pfs2.stage.mozilla.com picking up these updates.

I committed this JSON file and am not getting new results back.
DivX request:
http://pfs2.stage.mozilla.com/?callback=jsonp1254436893911&_=1254436894552&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appRelease=3.5.2&appVersion=20090910161356&clientOS=Win&chromeLocale=en-US&mimetype=video%2Fdivx

Response should have several releases in it.

As a sanity check I looked for the new gnome-totem.json record by requesting
http://pfs2.stage.mozilla.com/?callback=jsonp1254436893911&_=1254436894552&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appRelease=3.5.2&appVersion=20090910161356&clientOS=Linux%20i686&chromeLocale=en-US&mimetype=application/x-totem-plugin

Actual empty

Expected - 2 releases
FWIW, just checked in r53014, which should help this by changing from "os" property name to "os_name" as expected by the PFS2 JSON loader

Comment 5

8 years ago
I mistakenly put "os" instaed of "os_name" in the JSON files. Les fixed with r53014.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

8 years ago
Verified FIXED -- checked both Mac (OS X 10.5) and Windows DivX plugins; returned URLs are fine.
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.