520191 - Use ui.xxxx color preferences to override inverse themes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Instead of adding overrides to content.css and forking other CSS files, we can just use the color preferences to force named look-and-feel colors

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I pulled these colors from a linux screen capture of a webpage displayed in Firefox which used all the colors as background.

html:
http://people.mozilla.org/~mfinkle/colors-content.html

screenshot:
http://people.mozilla.org/~mfinkle/fennec/screenshots/fennec-colors.png

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 404269 [details] [diff] [review]
patch

I can't really test this... are we sure we need all of these colors?

This breaks the appearance of selected items in the profile selection dialog on Mac, which worries me a bit (both text and background color are orange).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 404269 [details] [diff] [review]
patch

>diff --git a/app/mobile.js b/app/mobile.js

>+pref("ui.highlighttext", "#1a1a1q");

this is what broke the profile selection: s/q/a/

I think we should probably just do this...

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Good catch. This does fix several other open bugs. I'll update them as well.

pushed:
https://hg.mozilla.org/mobile-browser/rev/4933459ae7f1