520262 - Cleanup database tables

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: cleanup db

I was looking for a place to store our maintenance flag and got sidetracked with these tables.  Looking for an r+ that we aren't actually using any of these in addition to me not breaking code.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: now with more clean

Comment 2

[Jeff Balogh (:jbalogh)]

Comment on attachment 404325 [details] [diff] [review]
now with more clean

A few more lines to remove:

controllers/components/developers.php
767: DELETE FROM reviewratings

tests/data/remora-test-data.sql1384155
415:-- Dumping data for table `reviewratings`

config/sql/anonymize.sql
20:TRUNCATE tshirt_requests;

Comment 3

[Wil Clouser [:clouserw]]

Thanks, r52782

"8 insertions(+), 400 deletions(-)" <- beltzner would be proud

Comment 4

[Wil Clouser [:clouserw]]

Turns out the FAMO codebase is so old it still needs favorites and reviewratings.  That's a ticking timebomb.