Cleanup database tables

RESOLVED FIXED in 5.2

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

unspecified

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 404324 [details] [diff] [review]
cleanup db

I was looking for a place to store our maintenance flag and got sidetracked with these tables.  Looking for an r+ that we aren't actually using any of these in addition to me not breaking code.
Attachment #404324 - Flags: review?(jbalogh)
(Assignee)

Comment 1

8 years ago
Created attachment 404325 [details] [diff] [review]
now with more clean
Attachment #404325 - Flags: review?(jbalogh)
(Assignee)

Updated

8 years ago
Attachment #404324 - Attachment is obsolete: true
Attachment #404324 - Flags: review?(jbalogh)
Comment on attachment 404325 [details] [diff] [review]
now with more clean

A few more lines to remove:

controllers/components/developers.php
767: DELETE FROM reviewratings

tests/data/remora-test-data.sql1384155
415:-- Dumping data for table `reviewratings`

config/sql/anonymize.sql
20:TRUNCATE tshirt_requests;
Attachment #404325 - Flags: review?(jbalogh) → review+
(Assignee)

Comment 3

8 years ago
Thanks, r52782

"8 insertions(+), 400 deletions(-)" <- beltzner would be proud
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

8 years ago
Turns out the FAMO codebase is so old it still needs favorites and reviewratings.  That's a ticking timebomb.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.