Closed Bug 520285 Opened 10 years ago Closed 10 years ago
urlbar pans to the right after opening/closing larry info
Build Id: Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002 Fennec/1.0b4 Steps to Reproduce: 1. Go to https://www.verisign.com/ 2. Open the tab sidebar 3. Open Larry information 4. Close larry information by clicking on the favicon 5. Pan to the right Actual Results: urlbar pans to the right with the rest of the browser, but the tab sidebar is still in place Expected Results: Urlbar shouldn't pan to the right
Severity: normal → major
tracking-fennec: --- → ?
taking. I can reproduce.
Assignee: nobody → 21
There was a previous discussion with Gavin about the fact we should balanced/unbalanced the call to BrowserUI.pushPopup/popPopup. He has convinced me that we can try to magically do it, but now I've realized that we have no way to know if someone has called the hide method (through a setTimeout for example).
Attachment #405494 - Flags: review?(mark.finkle)
Comment on attachment 405494 [details] [diff] [review] Patch I assume this patch needs to add a BrowserUI.popPopup(0 for the BookmarkPopup too? r+ with that and I can add it when checking in
Attachment #405494 - Flags: review?(mark.finkle) → review+
(In reply to comment #4) > (From update of attachment 405494 [details] [diff] [review]) > I assume this patch needs to add a BrowserUI.popPopup(0 for the BookmarkPopup > too? Good catch - I'm talking about unbalanced vs balanced and I'm doing a mix of them :) Thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED on builds: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091013 Fennec/1.0a4pre and Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091013 Fennec/1.0b5pre and Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091013 Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.