520285 - urlbar pans to the right after opening/closing larry info

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4

Steps to Reproduce:
1. Go to https://www.verisign.com/
2. Open the tab sidebar
3. Open Larry information
4. Close larry information by clicking on the favicon
5. Pan to the right

Actual Results:
urlbar pans to the right with the rest of the browser, but the tab sidebar is still in place

Expected Results:
Urlbar shouldn't pan to the right

Comment 1

[Aakash Desai [:aakashd]]

Screenshot: http://www.flickr.com/photos/42893104@N04/3975696016/

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

taking. I can reproduce.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

There was a previous discussion with Gavin about the fact we should balanced/unbalanced the call to BrowserUI.pushPopup/popPopup. 
He has convinced me that we can try to magically do it, but now I've realized that we have no way to know if someone has called the hide method (through a setTimeout for example).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 405494 [details] [diff] [review]
Patch

I assume this patch needs to add a BrowserUI.popPopup(0 for the BookmarkPopup too?

r+ with that and I can add it when checking in

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> (From update of attachment 405494 [details] [diff] [review])
> I assume this patch needs to add a BrowserUI.popPopup(0 for the BookmarkPopup
> too?

Good catch - I'm talking about unbalanced vs balanced and I'm doing a mix of them :)
Thanks!

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/00f79ede784d

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091013 Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091013
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091013
Fennec/1.0b5pre