520290 - lock icon is broken in the site identification popup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan]

Visit a non-secure site in Fennec. Click on the the site's favicon in the address bar to bring up the site identification popup. It will show an open lock and have the text Not encrypted.

Now do the same on a secure site (e.g. https://www.britishairways.com ) the same open lock icon with the text encrypted is shown.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: patch

Right, that's a bug :)
I'm not sure how it can have survive until here though.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/4fffc9ad24b9

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

This patch makes sure the "larry" image is correct, but does not fix the lock image

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 (fix the lock)

This patch makes the same kind of fix to the lock image too

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 406233 [details] [diff] [review]
patch 2 (fix the lock)

>diff --git a/themes/hildon/browser.css b/themes/hildon/browser.css

>+#identity-container[mode="verifiedIdentity"] > hbox> vbox > #identity-popup-encryption-icon ,
>+#identity-container[mode="verifiedDomain"] > hbox> vbox > #identity-popup-encryption-icon {

add a space after "hbox"?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

done and pushed:
https://hg.mozilla.org/mobile-browser/rev/d3f32828f319

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091015
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091015
Fennec/1.0b5pre