Closed Bug 520290 Opened 10 years ago Closed 10 years ago

lock icon is broken in the site identification popup

Categories

(Firefox for Android Graveyard :: General, defect, major)

Fennec 1.1
x86
Windows Vista
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0b5

People

(Reporter: kbrosnan, Assigned: mfinkle)

Details

(Whiteboard: [fennecb4testday])

Attachments

(2 files)

Visit a non-secure site in Fennec. Click on the the site's favicon in the address bar to bring up the site identification popup. It will show an open lock and have the text Not encrypted.

Now do the same on a secure site (e.g. https://www.britishairways.com ) the same open lock icon with the text encrypted is shown.
Whiteboard: [fennecb4testday]
Attached patch patchSplinter Review
Right, that's a bug :)
I'm not sure how it can have survive until here though.
Assignee: nobody → 21
Attachment #406003 - Flags: review?(mark.finkle)
Attachment #406003 - Flags: review?(mark.finkle) → review+
Summary: use a better lock icon in the site identification popup → lock icon is broken in the site identification popup
pushed:
https://hg.mozilla.org/mobile-browser/rev/4fffc9ad24b9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
This patch makes sure the "larry" image is correct, but does not fix the lock image
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This patch makes the same kind of fix to the lock image too
Assignee: 21 → mark.finkle
Attachment #406233 - Flags: review?(gavin.sharp)
Comment on attachment 406233 [details] [diff] [review]
patch 2 (fix the lock)

>diff --git a/themes/hildon/browser.css b/themes/hildon/browser.css

>+#identity-container[mode="verifiedIdentity"] > hbox> vbox > #identity-popup-encryption-icon ,
>+#identity-container[mode="verifiedDomain"] > hbox> vbox > #identity-popup-encryption-icon {

add a space after "hbox"?
Attachment #406233 - Flags: review?(gavin.sharp) → review+
done and pushed:
https://hg.mozilla.org/mobile-browser/rev/d3f32828f319
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091015
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091015
Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.