Closed Bug 520338 Opened 15 years ago Closed 15 years ago

Add toggletoolbar="true" to the windows that should have a Mac toolbar toggle pill

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

After bug 269410, we need to add toggletoolbar="true" to the window element in windows where we want the pill button to toggle the toolbar. Wouldn't really have to be [needs branch], but it's not like anyone's missing them in trunk builds, so there's no point in not waiting.
Whiteboard: [needs branch]
Attached patch FixSplinter Review
And "all that should have" is "not all that many" - the HIG explicitly says that windows that use a toolbar to pretend to be tabs, like the prefs window, should not have a pill.
Attachment #416691 - Flags: review?(bugzilla)
Whiteboard: [needs branch]
Comment on attachment 416691 [details] [diff] [review]
Fix

iirc there's some bug about the About window having a pill when it shouldn't have. I guess we can close that now can't we?
Attachment #416691 - Flags: review?(bugzilla) → review+
We can, except I think Marcus closed them all when he landed toggletoolbar="true".

http://hg.mozilla.org/comm-central/rev/a0fec491cb2b
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: