Closed
Bug 520353
Opened 16 years ago
Closed 16 years ago
querySelector(), querySelectorAll() and mozMatchesSelector() handle null and undefined incorrectly
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
()
Details
Attachments
(1 file)
|
4.89 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091002 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090926 Minefield/3.7a1pre
According to the Editor's Draft of Selectors API, [1] null and undefined should be converted to "null" and "undefined" respectively. This matches latest IE, Safari and Chrome. The same is true for matchesSelector, as defined in Selectors API 2. [2] I'll attach a patch.
[1] http://dev.w3.org/2006/webapi/selectors-api/#nodeselector
[2] http://dev.w3.org/2006/webapi/selectors-api2/#matchtesting
Reproducible: Always
Steps to Reproduce:
See testcase.
Actual Results:
Not all tests pass.
Expected Results:
All tests should pass.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #404409 -
Flags: review?(bzbarsky)
|
||
Updated•16 years ago
|
Assignee: nobody → Ms2ger
|
|
||
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 404409 [details] [diff] [review]
Patch
Looks good. Gotta love mutating specs....
Attachment #404409 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•16 years ago
|
||
Please comment with the changeset id when you push?
http://hg.mozilla.org/mozilla-central/rev/9bdbd962d2b1 was pushed to fix this on Oct 5.
Flags: in-testsuite+
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•