520380 - DivX® Web Player version 1.4.0.233 no url returned

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[Austin King [:ozten]]

Reported at http://blog.mozilla.com/webdev/2009/10/02/upyourplug-needs-your-help/comment-page-1/#comment-210467

The JSON file for DivX has urls setup for win and mac on the latest version, but no url specified for the old release 1.4.0.233. 

Expected:
UI should use the url from the latest release

Actual:
Need to investigate... either the latest release has no url, or the code is using the 1.4.0.233 url (which is empty).

Comment 1

[Austin King [:ozten]]

If we request video/divx the pfs2 results don't have any url properties.

The JSON file has 4 releases
        {
            "os": "win",
            "version": "1.5",
            "url": "http://www.divx.com/en/web-player-windows",
            "status": "latest"
        },
        {
            "os": "mac",
            "version": "1.5",
            "url": "http://www.divx.com/en/products/software/mac/divx",
            "status": "latest"
        },
        {
            "os": "*",
            "version": "1.4.1.4",
            "status": "outdated"
        },
        {
            "os": "*",
            "version": "1.4.0.233",
            "status": "outdated"
        }

Repro: 
1) edit divx-web-player.json to be in the state above
2) php bin/update-db
3) request http://pfs2.stage.mozilla.com/?callback=jsonp1254783861343&_=1254783861959&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appRelease=3.5.3&appVersion=20090824085743&clientOS=Linux+i686&chromeLocale=en-US&mimetype=video%2Fdivx

Actual:
no releases have url properties

Expected:
All releases should have the url set to the latest release for that platform

Comment 2

[Les Orchard [:lorchard]]

As it turns out, there are no per-release URLs in the DB.  Not sure why, but this will need a DB schema update (bug 520792) to fix.  I've got code to complete the fix, but it will break staging so I don't want to check it in just yet.

The one caveat though, is that the expected result is not quite right:

You will not see all releases get the URL for the latest release for a platform.  Each release (regardless of platform) will have either its own URL, or the URL set in the "meta" section of the definition.

Comment 3

[Austin King [:ozten]]

Ok, I will do the logic on the frontend end that the url will be taken from the "latest" release. 

If we don't have this logic somewhere, then we'd have to go back and change the urls of every previous release with the same criteria to a new url when a vendor changes their plugin url.

Comment 4

[Les Orchard [:lorchard]]

That's true(In reply to comment #3)
> Ok, I will do the logic on the frontend end that the url will be taken from the
> "latest" release. 
> 
> If we don't have this logic somewhere, then we'd have to go back and change the
> urls of every previous release with the same criteria to a new url when a
> vendor changes their plugin url.

That's true, but URLs change between versions per platform too, so I can't really enforce a rule across the board on the server

Comment 5

[Les Orchard [:lorchard]]

r52947 should now allow per-release URLs to work.

Thinking about this some more, it's probably best to use the latest URL on the client side for upgrade suggestions.  The thing is that the server is reporting on the known state of plugins - even the old detail URLs for vulnerable or out-of-date plugins.  Don't really want to throw out that historical data in case it becomes useful

Comment 6

[Les Orchard [:lorchard]]

Looks like URL is showing up for the releases that have them defined:

curl -s 'http://pfs2.stage.mozilla.com/?mimetype=video/divx&appID=%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D&appVersion=2008052906&appRelease=3.5el+Mac+OS+X+10.6&chromeLocale=ja-JP&ilovelamp' | prettyjson

[
    {
        "releases": {
            "others": [
                {
                    "status": "outdated", 
                    "app_release": "*", 
                    "os_name": "*", 
                    "vendor": "DivX, Inc", 
                    "description": "DivX Web Player lets you play up to HD-quality DivX\u00ae video in your web browser. You can also use DivX Web Player to easily embed DivX videos onto your website or blog.", 
                    "locale": "*", 
                    "modified": "2009-10-07T00:30:02+00:00", 
                    "name": "DivX\u00ae Web Player", 
                    "version": "1.4.1.4", 
                    "relevance": 2, 
                    "app_version": "*", 
                    "app_id": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}", 
                    "pfs_id": "divx-web-player"
                }, 
                {
                    "status": "outdated", 
                    "app_release": "*", 
                    "os_name": "*", 
                    "vendor": "DivX, Inc", 
                    "description": "DivX Web Player lets you play up to HD-quality DivX\u00ae video in your web browser. You can also use DivX Web Player to easily embed DivX videos onto your website or blog.", 
                    "locale": "*", 
                    "modified": "2009-10-07T00:30:02+00:00", 
                    "name": "DivX\u00ae Web Player", 
                    "version": "1.4.0.233", 
                    "relevance": 2, 
                    "app_version": "*", 
                    "app_id": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}", 
                    "pfs_id": "divx-web-player"
                }
            ], 
            "latest": {
                "status": "latest", 
                "app_release": "*", 
                "os_name": "*", 
                "vendor": "DivX, Inc", 
                "description": "DivX Web Player lets you play up to HD-quality DivX\u00ae video in your web browser. You can also use DivX Web Player to easily embed DivX videos onto your website or blog.", 
                "url": "http://www.divx.com/en/products/software/mac/divx", 
                "modified": "2009-10-07T00:30:02+00:00", 
                "name": "DivX\u00ae Web Player", 
                "locale": "*", 
                "version": "1.5", 
                "relevance": 2, 
                "app_version": "*", 
                "app_id": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}", 
                "pfs_id": "divx-web-player"
            }
        }, 
        "aliases": {
            "regex": [
                "DivX.? Web Player"
            ], 
            "literal": [
                "DivX Web Player", 
                "DivX\u00ae Web Player"
            ]
        }
    }
]

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Is bug 520355 a duplicate of this, or separate?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://www.mozilla.com/en-US/plugincheck/, both Windows and Mac.