520398 - Cmd+clicking back button no longer opens in new tab

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Hold Cmd
2. Click the back button

Result: goes back in the same tab

Expected: open previous page in a new tab

I noticed this while browsing with self-built rev 52a0e3de5593+ (a few hours old) on Mac.

Comment 1

[Dão Gottwald [:dao]]

Attachment: fix

This is because we lose event.ctrlKey & Co. when calling doCommand...

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Can anyone other than Vlad review this? He's on holiday this week ...

Comment 3

[Asaf Romano (gone)]

Comment on attachment 404494 [details] [diff] [review]
fix

This won't work for handlers added via addEventListener.

Comment 4

[Dão Gottwald [:dao]]

Attachment: fix

> This won't work for handlers added via addEventListener.

That's already an accepted shortcoming in checkForMiddleClick where I copied this code from. Added a comment to that effect.

Comment 5

[Dão Gottwald [:dao]]

Attachment: fix

Actually, bug 461578 makes more sense than bug 246720... adjusted the comment.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 406214 [details] [diff] [review]
fix

document.createEvent("xulcommandevent"...) should be used in both places.

Comment 7

[Dão Gottwald [:dao]]

Attachment: v2

Comment 8

[Asaf Romano (gone)]

Comment on attachment 406430 [details] [diff] [review]
v2

Please fix both places if possible.

r=mano either way.

Comment 9

[Dão Gottwald [:dao]]

I'm not going to touch checkForMiddleClick, as I can't initiate a command event with the appropriate button property.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/24809b522892

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/cd1e09235037