52042 - "Escape" classes inserted by our recognizer with moz-something

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Reply to a plaintext msg with an URL using the HTML composer
2. Send as HTML

In the HTML source of the quote, you'll see a lot of tags inserted by our
recognizer, and they contain classes invented by me. We have to recognize them
in various places, and we should make sure we don't collide with user-specified
(possibly in webpages) classes. Do this by prepending "-moz-". This is what
Gecko uses for "proprietary" stuff, too. I.e. this bug is about
future-compatibility.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What do you mean by classes?  -moz- is for css properties.

Comment 2

[Ben Bucksch (:BenB)]

> What do you mean by classes?

e.g. <a class="-moz-txt-link" href="...">...</a>

> -moz- is for css properties.

But I can use it for classes, too, not?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In theory, you can, although CSS1-2 idents can't start with -.  You might just
want to use moz- instead of -moz-, since defining classes is perfectly
legitimate, and the moz- establishes sort of namespace...

Comment 4

[Ben Bucksch (:BenB)]

> CSS1-2 idents can't start with -

ops, tnx for the notice!. Will use moz- instead.

Comment 5

[Ben Bucksch (:BenB)]

The hardest part was catching all places, where the classes were used. Will
attach patch.

mscott, please review.

The patch also contains various other minor changes, most notably updates for
the stylesheet.

Comment 6

[Ben Bucksch (:BenB)]

BTW: Part of the fix (changes in nsMsgCompose.cpp) is in the fix for bug 44552.

Comment 7

[Ben Bucksch (:BenB)]

Attachment: Fix, Version 1

Comment 8

[Ben Bucksch (:BenB)]

checked in.

Comment 9

[Tom Everingham]

verified.