520423 - Delete closing bracket when opening bracket is deleted

Status: RESOLVED INVALID

(Skywriter Graveyard :: Editor, enhancement)

Description

[Yehuda Katz]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_1; en-us) AppleWebKit/531.9 (KHTML, like Gecko) Version/4.0.3 Safari/531.9
Build Identifier: tip (2720:5850d6b621b5)

Deleting an opening paren/brace/bracket when a closing one is immediately to its right should delete that brace as well.

This patch adds a charAt method to the model, as well as an abstraction for working with pairs of braces, so the same basic logic could apply to creating and deleting opening braces.

Reproducible: Always

Steps to Reproduce:
1. Turn on closepairs mode
2. Type an open paren -- A close paren should be added
3. Immediately delete the open paren
Actual Results:  
The open paren is deleted, but the close paren remains.

Expected Results:  
The open and close paren should be deleted.

Comment 1

[Yehuda Katz]

Attachment: Deletes right brace when left brace is deleted

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

I've got a number of things to say about this bug:
1) I thought I included this feature in the original implementation of closepairs. Or, at least, I did when using undo/redo.
2) This is somewhat similar to bug 506088, though it may be valid as a separate bug.

Per those notes, I'm not sure how to categorize this: bug or enhancement? Same as bug 506088 or different? For now, I'm treating it as the latter in both questions.

Also, I'm changing the bug summary to make it much clearer what this bug is about.

Comment 3

[Kevin Dangoor]

ACETRANSITION

The Skywriter project has merged with Ajax.org's Ace project (the full server part of which is their Cloud9 IDE project). Background on the change is here:

http://mozillalabs.com/skywriter/2011/01/18/mozilla-skywriter-has-been-merged-into-ace/

The bugs in the Skywriter product are not necessarily relevant for Ace and quite a bit of code has changed. For that reason, I'm closing all of these bugs. Problems that you have with Ace should be filed in the Ace issue tracker at GitHub:

https://github.com/ajaxorg/ace/issues