Closed Bug 520474 Opened 12 years ago Closed 12 years ago

Remove unused helper function IsMenuPopup from nsContainerFrame.cpp

Categories

(Core :: Layout, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

References

()

Details

Attachments

(1 file)

Attached patch fixSplinter Review
The only caller of the static helper function "IsMenuPopup" was removed in Bug 508134 ( http://hg.mozilla.org/mozilla-central/rev/d483401d922f ).

As a result, we now get this compile warning when building nsContainerFrame:

> nsContainerFrame.cpp:458: warning: ‘PRBool IsMenuPopup(nsIFrame*)’ defined but not used

This function should be removed, now that it's unused.
Attachment #404526 - Flags: review?(dbaron)
Summary: Remove unused method IsMenuPopup → Remove unused helper function IsMenuPopup from nsContainerFrame.cpp
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 404526 [details] [diff] [review]
fix

r=dbaron
Attachment #404526 - Flags: review?(dbaron) → review+
I checked this in on 10/4, but forgot to close this bug.

http://hg.mozilla.org/mozilla-central/rev/9cdacc9f7c81
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.