520538 - -new-tab about:blank should focus the location bar

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Won't this change behavior in the loadDivertedInBackground=true case (will now focus the window and select the tab)? Seems like perhaps we should just call focusAndSelectURLBar() (being re-added by bug 494373) if we're loading about:blank here?

Comment 3

[Dão Gottwald [:dao]]

I think we actually want to ignore loadDivertedInBackground for the new-tab command from bug 518666.

Comment 4

[Dão Gottwald [:dao]]

Attachment: test added

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> I think we actually want to ignore loadDivertedInBackground for the new-tab
> command from bug 518666.

I agree, but I'm having a hard time trading that off with breaking the loadDivertedInBackground pref for other -new-tab about:blank loads. Even though the impact may be really low (hidden pref -> few people using it, etc.), the inconsistency irks me. We could instead add a -focus for that command to use, perhaps?

Comment 8

[Dão Gottwald [:dao]]

I don't really see the point of loading about:blank in a background tab. It's probably not what people touching that hidden pref had in mind. For that matter, I can't even think uses of -new-tab about:blank that shouldn't be translated to "open a new tab".

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 405029 [details] [diff] [review]
test added

OK, you make a convincing case!

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/5fca1946778b