Closed Bug 520547 Opened 11 years ago Closed 11 years ago

revert renaming of PlacesUtils methods from bug 477583

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: Gavin, Assigned: mak)

References

Details

Attachments

(1 file)

The patch for bug 477583 moved JSON import methods from PlacesUtils to PlacesUtils.backups, which breaks Fennec's use of restoreBookmarksFromJSONFile on the trunk.

I think we should undo it to maintain compat here, since the benefit seems rather small.
I'm going to restore a couple methods (saveBookmarksToJSON and restoreBookmarksFromJson), patch coming.
Status: NEW → ASSIGNED
Attached patch patch v1.0Splinter Review
since RestorebookmarksFromFile was not heavily dependant on backups object i've moved it out.
i did an heavier use of the object's self contained properties in saveBookmarksToJSONFile, so i've added back a stub backupBookmarksToFile that points to the method inside backups.

This should be enough to ensure a good compatibility imho, other methods were mostly used internally, and are better handled by the new methods.
Attachment #404700 - Flags: review?(gavin.sharp)
Comment on attachment 404700 [details] [diff] [review]
patch v1.0

r=mano
Attachment #404700 - Flags: review?(gavin.sharp) → review+
Comment on attachment 404700 [details] [diff] [review]
patch v1.0

r=me too, fwiw!
Attachment #404700 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/283fc12c827d

i'll merge this into the original bug
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.