Left arrow key in any tree with one selected item unselects the item

VERIFIED FIXED in Future

Status

()

P3
minor
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: bugzilla, Assigned: bugzilla)

Tracking

Trunk
Future
x86
Windows 98
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
Build ID: just pulled

Steps to Reproduce:
(1) Go to any tree in the app.
(2) Select one item in the tree.
(3) Press the left arrow key.

Result: The item is deselected.

Future me :P

Comment 1

18 years ago
Reporters future is secure, will future the bug instead ;-)
Target Milestone: --- → Future
(Assignee)

Comment 2

18 years ago
Fair enough! ;)

Anyways, I have a simple fix for this.  It was finding the tree itself as the 
parentNode and selecting it, when it should just be finding the parent folder.  
reassigning to me
Assignee: hyatt → blakeross
(Assignee)

Comment 3

18 years ago
Created attachment 14360 [details] [diff] [review]
patch
(Assignee)

Comment 4

18 years ago
Created attachment 14362 [details] [diff] [review]
better patch - old one worked fine, this just bullet proofs it
Overparenthesization aside, a=brendan@mozilla.org.

/be
(Assignee)

Comment 6

18 years ago
What can I say, I like parenthesizing.  There's no such thing as too much 
parenthesization!

fix checked in
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 7

18 years ago
Blake, a= is not the same thing as r=by the module owner.  You need both.  In 
the future, give me the opportunity to review.  Thanks!
(Assignee)

Comment 8

18 years ago
Hyatt: sorry.  I had written you about reviewing it, then bryner offered to so 
he did.  Next time I'll wait for your r=.

Comment 9

18 years ago
That's ok.  bryner's review is good enough for me... just mention it next 
time... ;)
(Assignee)

Comment 10

18 years ago
vrfy fixed in just-pulled build on win98
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.