520555 - Default command-click to open tabs

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, enhancement)

Description

[Stuart Morgan]

Attachment: tabs on by default

Tabs are well-established in browsers at this point, and Safari defaults command-click to on, so I think we can stop being concerned about confusing users (which IIRC was the only reason we hadn't done this before). I think it's more likely we'll confuse novice users into thinking we don't have good tabbed browsing support with our current behavior at this point.

(Yes, people deliberately using windows will have to change a pref once on update, but I don't think that's a big deal.)

Leaving UNCO for discussion.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

About @#$@# time.

In all seriousness, I think we're probably the last major browser to do this (I'd have to check) if Safari has finally done it, so, yeah, we should do this.

Comment 2

[Stuart Morgan]

Sounds like between this and IRC we have agreement, so confirming.

I meant to do this a long time ago, and just didn't get around to it :P

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 404611 [details] [diff] [review]
tabs on by default

>+// defaults for cmd-click opening windows or tabs (default to tabs)
>+pref("browser.tabs.opentabfor.middleclick", true);

This comment kind-of sucks (structure is odd and doesn't match others), so since you're changing it already, can you make it be something like:

"default to opening tabs instead of windows {on|for} cmd-click"

or

"cmd-click opens windows or tabs (default to tabs)"

if you want to keep closer to the current structure.

>+// ...and default to opening new tabs in the foreground
> pref("browser.tabs.loadInBackground", false);

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 404611 [details] [diff] [review]
tabs on by default

sr=pink

Comment 5

[Stuart Morgan]

Landed on trunk and CAMINO_2_0_BRANCH with improved comment.