Closed Bug 520570 Opened 16 years ago Closed 10 years ago

Use of #included structures and dynamically loading dso's considered harmful

Categories

(Core :: DOM: Geolocation, defect)

Product:
Core
Component:
DOM: Geolocation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dougt, Unassigned)

References

(
URL
)

Details

The wifi scanning code dlopen's various versions of the iwlib dso by including the SONAME in the file name. See above URL. This is fine, however, we also #include <iwlib.h>. If a future version of iwlib.h changes the layout of the structures we use, we may crash. The safest, yet cumbersome, thing we can do is to copy the structures from iwlib.h and put them in our source files.
We aren't dlopening iwlib or including its header anymore. I'm assuming we switched to a dbus service for this at some point.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.