Searchbox in Interactive translator is too small

VERIFIED FIXED in 1.4.2

Status

support.mozilla.org
Knowledge Base Software
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: JasnaPaka, Assigned: JasnaPaka)

Tracking

unspecified
1.4.2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tiki_triage (tiki_template?) tiki_upstreamed tiki_test, URL)

Attachments

(4 attachments, 3 obsolete attachments)

(Assignee)

Description

9 years ago
I cannot efficiently search strings in Interactive translator because input is too small.
(Assignee)

Comment 1

9 years ago
Created attachment 404654 [details]
Form which I'm talking about
(Assignee)

Comment 2

9 years ago
Created attachment 404657 [details] [diff] [review]
patch, v.1

I haven't tested this patch on some installation but I think it's good.
Attachment #404657 - Flags: review?
Attachment #404657 - Flags: review? → review?(james)
Thanks Pavel! I'll try this out and hopefully we can get it into 1.4.2.
Assignee: nobody → pcvrcek
Hardware: x86 → All
Target Milestone: --- → 1.4.2
Created attachment 407319 [details] [diff] [review]
v2

Added quotes around the values, just cause I like valid XHTML :)

I'll also post a screenshot. Pavel: take a look at it and let us know if you want it to be wider still (and how much wider) -- you can use firebug to play with the width.
Attachment #404657 - Attachment is obsolete: true
Attachment #407319 - Flags: review?(james)
Attachment #404657 - Flags: review?(james)
Created attachment 407320 [details]
size "30" box
Created attachment 407322 [details] [diff] [review]
v2

Oops, I included previous changes on my local. This patch is much shorter :)
Attachment #407319 - Attachment is obsolete: true
Attachment #407322 - Flags: review?(james)
Attachment #407319 - Flags: review?(james)
(Assignee)

Comment 7

9 years ago
(In reply to comment #4)
> I'll also post a screenshot. Pavel: take a look at it and let us know if you
> want it to be wider still (and how much wider) -- you can use firebug to play
> with the width.

It' ok for me. Thanks.
Attachment #407322 - Flags: review?(james) → review-
Comment on attachment 407322 [details] [diff] [review]
v2

I'm a jerk. :) But if you're going to nitpick the quoted attributes (which you should) then you should also quote the maxlength value. Then feel free to commit it, it's trivial.
Created attachment 407807 [details] [diff] [review]
v3

Lol. I must say I had a good laugh :)

r54001 (trunk) and I've also attached the patch.
Attachment #407322 - Attachment is obsolete: true
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Pavel: mind testing this out on http://support-stage.mozilla.org, when you get a chance?  Thanks!
Verified FIXED.
Status: RESOLVED → VERIFIED
r54132 (prod), r54133 (fennec)

Updated

9 years ago
Whiteboard: tiki_triage (tiki_template?)
Those values changed in trunk already. Not quite the same ones, but close enough.
Whiteboard: tiki_triage (tiki_template?) → tiki_triage (tiki_template?) tiki_upstreamed

Updated

9 years ago
Whiteboard: tiki_triage (tiki_template?) tiki_upstreamed → tiki_triage (tiki_template?) tiki_upstreamed tiki_test
You need to log in before you can comment on or make changes to this bug.