Closed Bug 520605 Opened 15 years ago Closed 6 years ago

Incorrect style context parent for first block part of {ib} split when first-line is used

Categories

(Core :: Layout: Block and Inline, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: bzbarsky, Unassigned)

References

Details

Attachments

(1 file)

Attached file Testcase
See attached testcase; only the "a" should be green.  Fix coming up.
Hmm.  This isn't as simple as it seemed, since the obvious fix (using the next sibling, not the prev one) runs into issues in ReParentStyleContext and ComputeStyleChangeFor....
And worse yet, in ReResolveStyleContext.
Assignee: bzbarsky → nobody
Keywords: helpwanted
This got fixed in the stylo ::first-line implementation.  See the commit message of https://hg.mozilla.org/mozilla-central/rev/d5d6e006b251 which describes this exact situation, and the test in layout/reftests/first-line/ib-split-1.html which tests for it.
Depends on: 1324619, stylo
Keywords: helpwanted
Should this get marked as WFM?
(In reply to Guilherme Lima from comment #4)
> Should this get marked as WFM?

Yes.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: