520623 - Building dehdyra against SpiderMonkey trunk fails

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Humphrey (:humph)]

Trying to build dehydra today with SpiderMonkey fails as follows:

cc -MD -g3 -Wall -fPIC -DXP_UNIX -DIN_GCC -DHAVE_CONFIG_H  -I/var/www/html/dxr/tools/gcc-dehydra/gcc-build/gcc -I/var/www/html/dxr/tools/gcc-dehydra/gcc-4.3.0/gcc -I/var/www/html/dxr/tools/gcc-dehydra/gcc-4.3.0/gcc/. -I/var/www/html/dxr/tools/gcc-dehydra/gcc-4.3.0/gcc/../include -I/var/www/html/dxr/tools/gcc-dehydra/gcc-4.3.0/gcc/../libcpp/include -I/var/www/html/dxr/tools/gcc-dehydra/gcc-4.3.0/gcc/../libdecnumber -I/var/www/html/dxr/tools/gcc-dehydra/gcc-4.3.0/gcc/../libdecnumber/bid -I/var/www/html/dxr/tools/gcc-dehydra/gcc-build/libdecnumber -I/var/www/html/dxr/tools/gcc-dehydra/gcc-build -I../../SpiderMonkey/include/js -I/var/www/html/dxr/tools/SpiderMonkey/lib -I//home/dave/local/include/js/   -c dehydra_plugin.c
In file included from ../../SpiderMonkey/include/js/jsapi.h:50,
                 from cp-tree-jsapi-workaround.h:6,
                 from gcc_cp_headers.h:26,
                 from dehydra_plugin.c:3:
../../SpiderMonkey/include/js/jsutil.h:186:12: error: attempt to use poisoned "malloc"
../../SpiderMonkey/include/js/jsutil.h:192:12: error: attempt to use poisoned "calloc"
../../SpiderMonkey/include/js/jsutil.h:198:12: error: attempt to use poisoned "realloc"
make: *** [dehydra_plugin.o] Error 1
ERROR - Dehydra build failed, aborting.

Comment 1

[(dormant account)]

Sorry about that. Update your gcc mq and qpush -a it


http://hg.mozilla.org/users/tglek_mozilla.com/gcc-moz-plugin-mq/rev/636c0157c6b3

and 

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/0ebf7084a6c4

Comment 2

[Arpad Borsos [:Swatinem]]

Reopening: This is still a problem with gcc 4.5 which does not have your patch applied. Fixing this in dehydra seems like a better solution.

Comment 3

[(dormant account)]

(In reply to comment #2)
> Reopening: This is still a problem with gcc 4.5 which does not have your patch
> applied. Fixing this in dehydra seems like a better solution.

Patch would be appreciated. You are right about my patch to gcc loosing momentum. I'm not super-excited about fighting gcc's poison policies if we can fix this within dehydra.

Comment 4

[Arpad Borsos [:Swatinem]]

Someone on the gcc mailing list suggested simply including jsapi before gcc headers, which seems to work for me where i have commented out / moved some includes.

I'm mainly worried about the stuff mentioned in cp-tree-jsapi-workaround.h which I am unable to test.
Will clean the patch up a bit and attach it later.

Comment 5

[Arpad Borsos [:Swatinem]]

Attachment: include reordering [pushed: comment 7]

This gets dehydra compiling on gcc 4.5, treehydra still fails due to bug 510190.

I'm unable to test with apples gcc 4.2 so someone else would need to verify that.

Comment 6

[(dormant account)]

Comment on attachment 410949 [details] [diff] [review]
include reordering [pushed: comment 7]

Thanks. Lets focus on getting Dehydra going 100%, Treehydra will be easier to do later once gcc source is more or less stable

Comment 7

[Arpad Borsos [:Swatinem]]

Comment on attachment 410949 [details] [diff] [review]
include reordering [pushed: comment 7]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/c360b56546c8