Closed Bug 520637 Opened 12 years ago Closed 12 years ago

Make Lightweight themes extend into the titlebar

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.3a1

People

(Reporter: mstange, Assigned: mstange)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch v1 (obsolete) — Splinter Review
This works with the patches in bug 515880 and bug 513158.
Attachment #404694 - Flags: review?(dao)
Comment on attachment 404694 [details] [diff] [review]
v1

>+#main-window[drawintitlebar="true"] #nav-bar {
>+  padding-top: 22px;
>+}

Would the window layout break horribly if that padding wasn't there? If so, this should probably be done in toolkit.
Good idea. The layout wouldn't break, but the titlebar controls would be painted on top of the back/forward button, and the top 22px strip of the window wouldn't be clickable, and... :)
Attachment #404694 - Flags: review?(dao)
Attached patch v2 (obsolete) — Splinter Review
Attachment #404694 - Attachment is obsolete: true
Attachment #405397 - Flags: review?(dao)
Comment on attachment 405397 [details] [diff] [review]
v2

> #ifdef XP_MACOSX
>-    if (active && aData.accentcolor) {
>-      root.setAttribute("activetitlebarcolor", aData.accentcolor);
>-      root.setAttribute("inactivetitlebarcolor", aData.accentcolor);
>+    if (active) {
>+      root.setAttribute("drawintitlebar", "true");
>     } else {
>-      root.removeAttribute("activetitlebarcolor");
>-      root.removeAttribute("inactivetitlebarcolor");
>+      root.removeAttribute("drawintitlebar");
>     }

nit: remove { and } as done elsewhere in this file

>+:root[drawintitlebar="true"] {
>+  padding-top: 22px;
>+}

It think xul.css with the appropriate ifdef might be a better place for this, since it's core platform behavior. Otherwise this would be yet another hurdle for themes trying to work cross-platform.
Attached patch v3Splinter Review
Attachment #405397 - Attachment is obsolete: true
Attachment #405429 - Flags: review?(dao)
Attachment #405397 - Flags: review?(dao)
Attachment #405429 - Flags: superreview?(enndeakin)
Attachment #405429 - Flags: review?(dao) → review+
Attachment #405429 - Flags: superreview?(enndeakin) → review?(enndeakin)
Attachment #405429 - Flags: review?(enndeakin) → review+
http://hg.mozilla.org/mozilla-central/rev/aefbd5d5df5b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Depends on: 524718
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091119 Minefield/3.7a1pre.  image is extended into title bar on osx.
Status: RESOLVED → VERIFIED
markus, any plans to get this into 1.9.2?
I'm afraid not, see bug 513158 comment 20.
Is there a bug filed on the black boxes I'm seeing around the window controls in the titlebar on a trunk build?
Not that I know of, no.
Duplicate of this bug: 547411
Duplicate of this bug: 554529
You need to log in before you can comment on or make changes to this bug.