520637 - Make Lightweight themes extend into the titlebar

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

This works with the patches in bug 515880 and bug 513158.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 404694 [details] [diff] [review]
v1

>+#main-window[drawintitlebar="true"] #nav-bar {
>+  padding-top: 22px;
>+}

Would the window layout break horribly if that padding wasn't there? If so, this should probably be done in toolkit.

Comment 2

[Markus Stange [:mstange]]

Good idea. The layout wouldn't break, but the titlebar controls would be painted on top of the back/forward button, and the top 22px strip of the window wouldn't be clickable, and... :)

Comment 3

[Markus Stange [:mstange]]

Attachment: v2

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 405397 [details] [diff] [review]
v2

> #ifdef XP_MACOSX
>-    if (active && aData.accentcolor) {
>-      root.setAttribute("activetitlebarcolor", aData.accentcolor);
>-      root.setAttribute("inactivetitlebarcolor", aData.accentcolor);
>+    if (active) {
>+      root.setAttribute("drawintitlebar", "true");
>     } else {
>-      root.removeAttribute("activetitlebarcolor");
>-      root.removeAttribute("inactivetitlebarcolor");
>+      root.removeAttribute("drawintitlebar");
>     }

nit: remove { and } as done elsewhere in this file

>+:root[drawintitlebar="true"] {
>+  padding-top: 22px;
>+}

It think xul.css with the appropriate ifdef might be a better place for this, since it's core platform behavior. Otherwise this would be yet another hurdle for themes trying to work cross-platform.

Comment 5

[Markus Stange [:mstange]]

Attachment: v3

Comment 6

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/aefbd5d5df5b

Comment 7

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091119 Minefield/3.7a1pre.  image is extended into title bar on osx.

Comment 8

[Tony Chung [:tchung]]

markus, any plans to get this into 1.9.2?

Comment 9

[Markus Stange [:mstange]]

I'm afraid not, see bug 513158 comment 20.

Comment 10

[(not currently active) Ted Mielczarek]

Is there a bug filed on the black boxes I'm seeing around the window controls in the titlebar on a trunk build?

Comment 11

[Markus Stange [:mstange]]

Not that I know of, no.