520642 - Rewrite sphinx conf file in python

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Conf files can be shell scripts, use the standard python way of getting DB settings to populate the config file.

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v1

* Moved the sphinx config to its own directory
* Wrote a localsettings.py which reads config.php to get mysql settings and can be overridden by IT without much fuss.

This will help Chizu to be able to automate sphinx updates.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 404727 [details] [diff] [review]
v1

r- because this has a ton of .po file changes (?)

Also, we're already reading the settings out of config.php for the migration scripts.  Can't we add these settings to config.php and read them out with python as well?  That way we could keep all the config in one file.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Sorry the diff was probably bad.  I accidentally checked this (the sphinx conf) in this morning  :/

But for the record it *does* read the config.php file like the migration scripts, etc.  So you wouldn't have to change anything.  The localsettings.py just reads config.php (using the migrations code).

Sorry about the accidental check in, I was fixing something in the prime-sphinx-index.py script and forgot about this change:

http://viewvc.svn.mozilla.org/vc?view=revision&revision=52935