If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update footer links and About page

VERIFIED FIXED in 5.3

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: fligtar, Assigned: fligtar)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Some of the links in the footer don't need to be in the footer if we make our About page better. We should update the About page and re-assess the footer links.
(Assignee)

Comment 1

8 years ago
Created attachment 405150 [details] [diff] [review]
patch, v1

I got a bit carried away.
Attachment #405150 - Flags: review?(clouserw)
(Assignee)

Updated

8 years ago
Attachment #405150 - Attachment is patch: true
Attachment #405150 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 405150 [details] [diff] [review]
patch, v1

(In reply to comment #0)
> Some of the links in the footer don't need to be in the footer if we make our
> About page better. We should update the About page and re-assess the footer
> links.

So, the only link you took out of the footer was "Credits" and you added hundreds of new words to localize.  The localizers are already taxed with the developer hub, this wasn't a great time to do a huge rewrite.

+<p><?=sprintf(___('For information on contributing, please see our %s.'), $html->link(___('wiki page'), 'http://wiki.mozilla.org/AMO'))?></p>
Concatenating strings here doesn't make sense.  You need to use 1 string and add an L10n comment.
Attachment #405150 - Flags: review?(clouserw) → review+
(Assignee)

Comment 3

8 years ago
I'll hold off on this until 5.3, although I think we need a better priority tier system with the localizers so they understand what is important and what isn't important to localize for the current release. I don't like not being able to make easy en-US improvements just because localizers will assume they have to have it perfectly translated ASAP when it's not the case.

Things like this will only occur more frequently going forward as we do en-US-only A/B tests and copy improvements.

Re: the concatenation, I only updated the wiki page's URL, everything else was already there (and already translated). But I'll fix it and make a new string since I'm so good at making new strings!
Target Milestone: 5.2 → 5.3
(Assignee)

Comment 4

8 years ago
r54405
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: push-needed
Resolution: --- → FIXED
Thanks, Justin; verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/pages/about (page itself and the global footer).
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.