nsBrowserInstance.cpp has evil refcounting habits

VERIFIED FIXED

Status

SeaMonkey
UI Design
P3
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

Trunk
All
Mac System 8.5

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
See the URl for some heinous refcounting behaviour by nsBrowserInstance. It has *
public* methods that return non-refcounted interface pointers. Luckily, these are 
only used internally right now.
(Assignee)

Comment 1

18 years ago
Created attachment 14358 [details] [diff] [review]
nsBrowserInstance.h patch
(Assignee)

Comment 2

18 years ago
Created attachment 14359 [details] [diff] [review]
nsBrowserInstance.cpp patch
(Assignee)

Comment 3

18 years ago
I'll take this.
Assignee: law → sfraser
(Assignee)

Comment 4

18 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
more or less rubberstamp vrfy. doing reload, back, fwd still seem to work, tho',
fwiw.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.