520763 - "Run Now" button isn't working in the mail filters dialog

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Prasad Sunkari [:prasad]]

Attachment: Fix v1

In the message filters dialog...

Select a filter and click "Run Now". The expected result is to run the filter on the selected folder but it does not happen.

1. The drop down menu that displays the folder to apply the filters on should not show the list of accounts, but only show the account whose filters are currently being shown.

2. Even the list of accounts shown in the drop down don't expand to the folders in the drop down menu.

3. folderWidgets.xml needs widgetglue.js to be included in the dialog.

Comment 1

[paule]

Newly created filters are not executed when the "Run Now" button is clicked

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #0)
> Select a filter and click "Run Now". The expected result is to run the filter
> on the selected folder but it does not happen.

This works for me, are there particular instances where it doesn't happen?

> 1. The drop down menu that displays the folder to apply the filters on should
> not show the list of accounts, but only show the account whose filters are
> currently being shown.

I don't see this on current trunk. 

> 2. Even the list of accounts shown in the drop down don't expand to the folders
> in the drop down menu.

I don't understand what you're trying to say here.

> 3. folderWidgets.xml needs widgetglue.js to be included in the dialog.

Why? From what I can see neither of the two functions in widgetglue.js are used in folderWidgets.xml.

-              <menupopup id="runFiltersPopup" type="folder"
-                         showFileHereLabel="true"
-                         fileHereLabel="&filemessageschoosethis.label;"/>
+              <menupopup id="runFiltersPopup" type="folder" mode="filing"
+                         showFileHereLabel="false"/>

For some reason the menu still has the space for the "fileHereLabel" in sub folders. You'll also need ui-review if you want to change this - I don't see a particular reason to change what is there now.

-   runMenu._parentFolder = msgFolder;
+   runMenu.parentFolder = msgFolder;

For my future reference: this is a sensible change to make, but doesn't actually affect anything on current builds.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 404808 [details] [diff] [review]
Fix v1

and I also meant to say, sorry for the delay in getting to look at this.

Comment 4

[Prasad Sunkari [:prasad]]

> 
> This works for me, are there particular instances where it doesn't happen?
> 

Sorry. There was a mistake on my part.
My tree was on the beta 4 branch when I tested and ran this!

These problems did exist in the Beta 4 release and got fixed via bug 516353 on the trunk.

Sorry again :)

Comment 5

[paule]

When will the fixed version be released?

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
> When will the fixed version be released?

https://wiki.mozilla.org/Thunderbird/StatusMeetings/2009-10-13 we talk about it on our status meetings.