520767 - calendar-event-dialog-freebusy.xml should use getAnonymousElementByAttribute in place of getElementById.

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Prasad Sunkari [:prasad]]

Attachment: [checked in] Fix

... silly mistake but causes not displaying the freebusy status.

Comment 1

[Stefan Sitter [:ssitter]]

The first change in the patch is already covered by Bug 520399.

Comment 2

[Decathlon]

(In reply to comment #1)
> The first change in the patch is already covered by Bug 520399.

I think this bug is more general than bug 520339, so that one can be marked as duplicate of this one.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 404815 [details] [diff] [review]
[checked in] Fix

I kind of wonder what we are actually *doing* in that file. A binding must not have anything with an "id" attribute, since it could be used more than once and the "id" attribute must be unique in the document. prasad (or Decathlon?) could you investigate why and if possible change id="..." to anonid="..." in that file?

Comment 5

[Prasad Sunkari [:prasad]]

will look at it

Comment 6

[Stefan Sitter [:ssitter]]

I suggest to fix the issue now using the attached patch and proceed with investigation afterwards.

Comment 7

[Bernd Kuemmerlen]

I have been experiencing "No information" display in Lightning and Sunbird 1.0pre (using CalDAV talking to an Exchange server through DavMail). The patch fixes this problem for me, so I would appreciate if it could find its way into 1.0

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 404815 [details] [diff] [review]
[checked in] Fix

r=mschroeder

Comment 9

[Martin Schröder [:mschroeder]]

Comment on attachment 404815 [details] [diff] [review]
[checked in] Fix

http://hg.mozilla.org/comm-central/rev/2959a8440c9d
http://hg.mozilla.org/releases/comm-1.9.1/rev/4a902dce3503

Comment 10

[Martin Schröder [:mschroeder]]

We need a follow-up patch to fix the usage of "id" attributes. Two of them can be easily replaced by the "anonid" with the same value ("day-column", "grid-column"). Replacing the "id" attribute with value "attendeeCol4#1" seems to be more complicated because the element uses an "id" and "anonid" attribute.

Comment 11

[Martin Schröder [:mschroeder]]

Attachment: [checked in] Replace id with anonid (easy fix)

This just fixes the two easy cases, but for the third one I still try to understand how all those XBL bindings for the freebusy dialog work and could be simplified.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 411070 [details] [diff] [review]
[checked in] Replace id with anonid (easy fix)

Looks good, r=philipp

Comment 13

[Martin Schröder [:mschroeder]]

Comment on attachment 411070 [details] [diff] [review]
[checked in] Replace id with anonid (easy fix)

http://hg.mozilla.org/comm-central/rev/dada8caded1b

http://hg.mozilla.org/releases/comm-1.9.1/rev/73549b0972eb

Comment 14

[Bernd Kuemmerlen]

I don't see any recent activity here, is this something that could be considered for 1.0?

Comment 15

[Martin Schröder [:mschroeder]]

(In reply to comment #14)
> I don't see any recent activity here, is this something that could be
> considered for 1.0?

Could be considered for 1.0? Yes! But I haven't found time to work on this bugs in the last 6 months.

Comment 16

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I think we have these covered, I couldn't find getElementById in calendar/base/content/dialogs/*.xml