[gl] Remove answers from list.txt, and clean browser/searchplugins directory

RESOLVED FIXED

Status

Mozilla Localizations
gl / Galician
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: stas, Unassigned)

Tracking

({productization})

unspecified
productization

Firefox Tracking Flags

(status1.9.2 beta4-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/gl/file/03bdcd8fe2e3/browser/searchplugins has some unnecessary files: google.xml, creativecommons.xml and answers.com. Please 'hg remove' them from the repository. (They will be included in the build anyways, since they're mentioned in list.txt.)

'answers' should not be in list.txt, though (according to the reference at <http://hg.mozilla.org/l10n/l10n-src-verification/file/706ae017a258/reference/1.9.2/gl/list.txt>).

Please attach a patch for review before landing.

Thanks!

Comment 1

9 years ago
Created attachment 405018 [details] [diff] [review]
patch for removing "answers" in plugins

Hi: 

Please, find attached the patch for removing the answers line in the searchplugins file.

Thanks.
Attachment #405018 - Flags: review+

Comment 2

9 years ago
I forgot to mention that I already "hg remove" those files (google.xml, creativecommons.xml and answers.xml)

Frco. Javier Rial.
(Reporter)

Updated

9 years ago
Attachment #405018 - Flags: review+
(Reporter)

Comment 3

9 years ago
Comment on attachment 405018 [details] [diff] [review]
patch for removing "answers" in plugins

r=me. Please land this patch on 1.9.2 today with a descriptive comment. When you land, please post in .l10n in the opt-in thread to make sure Axel has the new opt-in revision. Once he approves, please set the "status1.9.2" flag in this bug to "beta1-fixed" and close the bug.

In the future, please use "hg diff -p -U 8" to create patches. Thanks!

Comment 4

9 years ago
Updated and pushed to 1.9.2.
Also, posted in opt-in thread for firefox 3.6 beta1,
Waiting approval from Axel (I don't know how this works, should I have to ask Axel for something in the opt-in thread or do I have to ask his approval here, in bugzilla??.

I don't know, but, please, if you need something else, just ask.
thanks for your help Staś

Javier Rial
(Reporter)

Comment 5

9 years ago
(In reply to comment #4)
> Updated and pushed to 1.9.2.
> Also, posted in opt-in thread for firefox 3.6 beta1,
> Waiting approval from Axel (I don't know how this works, should I have to ask
> Axel for something in the opt-in thread or do I have to ask his approval here,
> in bugzilla??.

Your post to .l10n is perfectly fine, this is exactly what I had in mind. Thanks.

> I don't know, but, please, if you need something else, just ask.
> thanks for your help Staś

Thank *you*, Javier!

Comment 6

9 years ago
According to l10n-src-verification, we have this on 1.9.2. Marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
status1.9.2: --- → beta4-fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.