Closed Bug 520898 Opened 16 years ago Closed 16 years ago

OP_getlocal[0-3]* in Verifier.cpp need to call checkLocal() earlier

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
flash10.1

People

(Reporter: stejohns, Assigned: stejohns)

Details

Attachments

(1 file)

When the Verifier was refactored, the calls to checkLocal() for these calls got moved into the call to push(), but needs to be called prior to coder->write(), to protect against bad values for the immediate value. (This is how the Verifier has been in all previous shipping versions, and is a recent injection.)
Attached patch PatchSplinter Review
Fix.
Assignee: nobody → stejohns
Attachment #404947 - Flags: review?(edwsmith)
Priority: -- → P3
Target Milestone: --- → flash10.1
Attachment #404947 - Flags: review?(edwsmith) → review+
pushed as changeset: 2716:393f3bfcf4dc
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: