Closed Bug 520901 Opened 11 years ago Closed 10 years ago

Switch application/x-javascript to application/javascript, Composer part

Categories

(Composer Graveyard :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sgautherie, Assigned: Tobbi)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

"Found 139 matching lines in 44 files".

Hint: use a tool.
Whiteboard: [good first bug]
Depends on: 477840
Target Milestone: --- → Future
This patch should replace all occurrences of application/x-javascript with application/javascript
Assignee: daniel → tobbi.bugs
Status: NEW → ASSIGNED
Attachment #420310 - Flags: review?(neil)
Comment on attachment 420310 [details] [diff] [review]
Replacing all occurrences of application/x-javascript with application/javascript

>diff -r c8d6c2af216a editor/ui/composer/content/ComposerCommands.js
06 14:31:34 2010 +0100
>@@ -1637,7 +1637,7 @@
>   "application/javascript",
>   "application/ecmascript",
>-  "application/x-javascript",
>+  "application/javascript",

Wrong: this list remains fine as is.


>+  <script type="application/javascript" src="chrome://global/content/dialogOverlay.js" />

Nit: while there, could you remove the "ending" space on the lines you're updating? Thanks.
Attachment #420310 - Attachment is obsolete: true
Attachment #420310 - Flags: review?(neil)
(In reply to comment #2)
> (From update of attachment 420310 [details] [diff] [review])
> >diff -r c8d6c2af216a editor/ui/composer/content/ComposerCommands.js
> 06 14:31:34 2010 +0100
> >@@ -1637,7 +1637,7 @@
> >   "application/javascript",
> >   "application/ecmascript",
> >-  "application/x-javascript",
> >+  "application/javascript",
> 
> Wrong: this list remains fine as is.

That happens when you just replace all occurrences and don't pay attention.

> 
> >+  <script type="application/javascript" src="chrome://global/content/dialogOverlay.js" />
> 
> Nit: while there, could you remove the "ending" space on the lines you're
> updating? Thanks.

Sure, I'm on it.
This should fix it, finally.
Attachment #420314 - Flags: review?(neilio)
Attachment #420314 - Flags: review?(sgautherie.bz)
Attachment #420314 - Flags: review?(sgautherie.bz)
Attachment #420314 - Flags: review?(neilio)
Attachment #420314 - Flags: review?(neil)
Think you have the wrong person tagged for review here - maybe you meant Neil Deakin?
Comment on attachment 420314 [details] [diff] [review]
new patch fixing the spaces at the end and leaving the MIME type list as is

Simple enough patch, that I feel comfortable dropping Neil's queue down by 1 here.

In future, I at least prefer a bit more diff context, try -u6 or -u8 please.
Attachment #420314 - Flags: review?(neil) → review+
$ hg outgoing && hg push
comparing with ssh://hg.mozilla.org/comm-central/
searching for changes
changeset:   4637:74c9062c3d27
tag:         tip
user:        Tobias Markus <tobbi.bugs>
date:        Wed Jan 06 06:35:00 2010 -0500
summary:     Bug 520901 - "Switch application/x-javascript to application/javasc
ript, Composer part" [r=bugspam.Callek]

pushing to ssh://hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 43 changes to 43 files
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
No longer depends on: 477840
Whiteboard: [good first bug]
Target Milestone: Future → ---
V.Fixed, per MXR.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.