520906 - Forum Search page results broken

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P2)

Description

[Noah (NoahSUMO/SolidSnake) [:Noah]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090626 Firefox/3.5
Build Identifier: 

Using the "Search previous questions in the forum" box on stage & prod, Forum searches will not display results past page 1.

I even tried a search from the Firefox Support Home page's "Search the Knowledge Base" box(https://support-stage.mozilla.org/en-US/kb/Firefox+Support+Home+Page) - all page results there worked correctly.

Stephend noticed that on the broken pages you see:
" search results for "connect" in "

You should see:
About 151 search results for "connect" in English 

Stephend says that means it didn't pass the language param or at least doesn't print it out.

Reproducible: Always

Steps to Reproduce:
1. Login to stage: https://support-stage.mozilla.org/tiki-login.php?locale=en-US
2. Visit https://support-stage.mozilla.org/en-US/kb/Support+Website+Forums
3. In the "Search previous questions in the forum" box, type any search term and press enter - I used 'connect'
4. After being redirected to page 1 of the results, click the number 2 link (or 3 or 4, etc)
5. You will end up at a page without search results with the message:
No pages matched the search criteria 

The same will be true for any page of results after the first page.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, Noah; marking as confirmed (NEW).

Comment 2

[Noah (NoahSUMO/SolidSnake) [:Noah]]

Even though the STR allude to this, I forgot to explicitly state that you must be logged in to reproduce the bug. What account type you are may matter, I'm a contributor.

Tested on stage as a guest, and search results appear on all pagination links tried.

Comment 3

[James Socol [:jsocol, :james]]

While logged in or logged out, the "locale" parameter in the query string is "en". Changing it to "en-US" while logged in seems to restore the results when logged in.

Either the pagination needs to use "en-US" or there is something changing "en" to "en-US" that's only happening when logged out. Probably both.

Comment 4

[Paul Craciunoiu [:paulc]]

Search functionality is broken in many-many ways, both the template and the code are very unintuitive, and as we see over time, with weird exceptions. My vote is to just wait on fixing search bugs until the rewrite, except when the bug is critical or frequent. Hope this one is a simple fix, at least :)

Comment 5

[James Socol [:jsocol, :james]]

We can't leave issues open for two months. After 1.4.x we'll be waiting on the search rewrite anyway, but something like this needs fixing.

Comment 6

[James Socol [:jsocol, :james]]

I've been banging my head against this without making any progress. Paul, can you take a look?

Comment 7

[Paul Craciunoiu [:paulc]]

Still catching up on stuff after being away for a week, but I will at least take a look. Fingers crossed :)

Comment 8

[[:Cww]]

can we for the time being replace the forum search with a KB + forum search?

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: v1

The decision of whether to search the forums or documents index was made based on the value of the locale, which doesn't really make sense. This one line patch should fix things.

Comment 10

[James Socol [:jsocol, :james]]

Comment on attachment 406389 [details] [diff] [review]
v1

Looks good.

Comment 11

[Paul Craciunoiu [:paulc]]

r53457

QA: Please make sure pagination works in at least all of these cases:
1) Logged out, search with where=f, where=all, where=d (forums, forums+kb, kb respectively). I think the kb (where=d) case is not covered by any of the search boxes; however, please make sure the two large search boxes work (from main homepage and forum homepage), as well as the sidebar search.
2) Logged in as contributor, same cases as item 1)
3) Logged in as admin, same cases as item 1)

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I've run:

* http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/tests/frontend/anon_search%20in%20forum.html?view=log
* http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/tests/frontend/anon_search_on_homepage.html?view=log
* http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/tests/frontend/loggedin_search_on_homepage.html?view=log
* http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/tests/frontend/tiki-searchresults.html?view=log

As well as tested the cases in comment 11; (had to accomodate for explicit "login" commands in those Selenium cases by manually testing some, instead.)

Comment 13

[Paul Craciunoiu [:paulc]]

r53575 (prod) / r53576 (fennec)