520937 - Win7 related errors on browser startup.

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Nochum Sossonko [:Natch]]

Error: Cc[WINTASKBAR_CONTRACTID] is undefined
Line: 2533
Source File: chrome://browser/content/browser.js
________________________________________

Warning: reference to undefined property Cc[WINTASKBAR_CONTRACTID]
Line: 2533
Source File: chrome://browser/content/browser.js

I get these errors/warnings when I startup on trunk.

Comment 1

[Nochum Sossonko [:Natch]]

That was added by Rob Arnold in bug 474056.

Comment 2

[[not reading bugmail]]

Do taskbar previews work for you?   See bug 520801.

Comment 3

[Jim Mathies [:jimm]]

Attachment: components check v.1

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 405164 [details] [diff] [review]
components check v.1

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>+  if (!(WINTASKBAR_CONTRACTID in Cc))
>+    return { onOpenWindow: function () {}, onCloseWindow: function () {} };
>+
>   let taskbar = Cc[WINTASKBAR_CONTRACTID].getService(Ci.nsIWinTaskbar);
>   if (taskbar.available) {

I'd prefer:

if (WINTASKBAR_CONTRACTID in Cc &&
    Cc[WINTASKBAR_CONTRACTID].getService(Ci.nsIWinTaskbar).available) {

Comment 5

[Jim Mathies [:jimm]]

Attachment: components check

Comment 6

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/63c6082e6230

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 405166 [details] [diff] [review]
components check

a192=beltzner

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #7)
> (From update of attachment 405166 [details] [diff] [review])
> a192=beltzner

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/98bdd45f7c91

Comment 9

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091008 Minefield/3.7a1pre
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b1pre) Gecko/20091008 Namoroka/3.6b1pre

V. Fixed. I get no errors now.