The default bug view has changed. See this FAQ.

move greprefs/*js into greprefs.js, SeaMonkey part

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Preferences
--
blocker
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug, {fixed-seamonkey2.0, regression})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0, regression
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
We probably need to port Thunderbird patch:
http://hg.mozilla.org/comm-central/rev/41a1857f1987

But, note that patch is wrong in that m-1.9.2 too still needs the old files!

(Fwiw, calendar should be updated too...)
(Assignee)

Comment 1

8 years ago
Created attachment 405054 [details] [diff] [review]
(Av1) Update installer files, Improve order and comments
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #405054 - Flags: review?(kairo)
Attachment #405054 - Flags: approval-seamonkey2.0?
(Assignee)

Updated

8 years ago
Blocks: 521009
(In reply to comment #0)
> But, note that patch is wrong in that m-1.9.2 too still needs the old files!

I decided that as its a Fennec start up issue the patch would most likely land on 1.9.2. Once we start actively building 1.9.2 we're going to have to be doing a bit of sorting out anyway so I didn't care too much for it at this time.
Blocks: 507288
No longer depends on: 507288
Blocks: 521192
Comment on attachment 405054 [details] [diff] [review]
(Av1) Update installer files, Improve order and comments

As per bug 521192, this has busted linux trunk builds to an extent that even updates don't work.

Therefore stealing review and I'll land this as well so we can get a resonable build out for trunk at least. r+a=Standard8.
Attachment #405054 - Flags: review?(kairo)
Attachment #405054 - Flags: review+
Attachment #405054 - Flags: approval-seamonkey2.0?
Attachment #405054 - Flags: approval-seamonkey2.0+
Checked in: http://hg.mozilla.org/comm-central/rev/5401ade8151a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
(Assignee)

Comment 5

8 years ago
(In reply to comment #0)
> But, note that patch is wrong in that m-1.9.2 too still needs the old files!
> (Fwiw, calendar should be updated too...)

Bug 521192 will fix these :-)

(In reply to comment #2)
> I decided that as its a Fennec start up issue the patch would most likely land
> on 1.9.2. Once we start actively building 1.9.2 we're going to have to be doing
> a bit of sorting out anyway so I didn't care too much for it at this time.

You may be right, but, as there is no sign of it (yet), I prefer to sync' with the current code.
(And, fwiw, I feel like c-c should better skip m-1.9.2 eventually, as we skipped m-1.9.0.)

(In reply to comment #3)
> Therefore stealing review and I'll land this as well

You should do that more often ;-)
Severity: trivial → blocker
Flags: in-testsuite-
Keywords: fixed-seamonkey2.0, regression
Target Milestone: seamonkey2.0 → seamonkey2.1a1

Comment 6

8 years ago
(In reply to comment #3)
> Therefore stealing review and I'll land this as well so we can get a resonable
> build out for trunk at least. r+a=Standard8.

Thanks, Mark. I didn't realize that it would break things so badly, and I was swamped with 2.0rc1 work, that's why the review stalled for a bit.
You need to log in before you can comment on or make changes to this bug.