Last Comment Bug 521004 - move greprefs/*js into greprefs.js, SeaMonkey part
: move greprefs/*js into greprefs.js, SeaMonkey part
Status: RESOLVED FIXED
: fixed-seamonkey2.0, regression
Product: SeaMonkey
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: All All
: -- blocker (vote)
: seamonkey2.1a1
Assigned To: Serge Gautherie (:sgautherie)
:
:
Mentors:
Depends on:
Blocks: 521009 507288 521192
  Show dependency treegraph
 
Reported: 2009-10-07 08:31 PDT by Serge Gautherie (:sgautherie)
Modified: 2009-10-08 06:36 PDT (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Update installer files, Improve order and comments (3.49 KB, patch)
2009-10-07 09:11 PDT, Serge Gautherie (:sgautherie)
standard8: review+
standard8: approval‑seamonkey2.0+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2009-10-07 08:31:27 PDT
We probably need to port Thunderbird patch:
http://hg.mozilla.org/comm-central/rev/41a1857f1987

But, note that patch is wrong in that m-1.9.2 too still needs the old files!

(Fwiw, calendar should be updated too...)
Comment 1 Serge Gautherie (:sgautherie) 2009-10-07 09:11:04 PDT
Created attachment 405054 [details] [diff] [review]
(Av1) Update installer files, Improve order and comments
Comment 2 Mark Banner (:standard8) 2009-10-07 11:11:22 PDT
(In reply to comment #0)
> But, note that patch is wrong in that m-1.9.2 too still needs the old files!

I decided that as its a Fennec start up issue the patch would most likely land on 1.9.2. Once we start actively building 1.9.2 we're going to have to be doing a bit of sorting out anyway so I didn't care too much for it at this time.
Comment 3 Mark Banner (:standard8) 2009-10-08 01:43:23 PDT
Comment on attachment 405054 [details] [diff] [review]
(Av1) Update installer files, Improve order and comments

As per bug 521192, this has busted linux trunk builds to an extent that even updates don't work.

Therefore stealing review and I'll land this as well so we can get a resonable build out for trunk at least. r+a=Standard8.
Comment 4 Mark Banner (:standard8) 2009-10-08 02:12:46 PDT
Checked in: http://hg.mozilla.org/comm-central/rev/5401ade8151a
Comment 5 Serge Gautherie (:sgautherie) 2009-10-08 06:05:26 PDT
(In reply to comment #0)
> But, note that patch is wrong in that m-1.9.2 too still needs the old files!
> (Fwiw, calendar should be updated too...)

Bug 521192 will fix these :-)

(In reply to comment #2)
> I decided that as its a Fennec start up issue the patch would most likely land
> on 1.9.2. Once we start actively building 1.9.2 we're going to have to be doing
> a bit of sorting out anyway so I didn't care too much for it at this time.

You may be right, but, as there is no sign of it (yet), I prefer to sync' with the current code.
(And, fwiw, I feel like c-c should better skip m-1.9.2 eventually, as we skipped m-1.9.0.)

(In reply to comment #3)
> Therefore stealing review and I'll land this as well

You should do that more often ;-)
Comment 6 Robert Kaiser 2009-10-08 06:36:54 PDT
(In reply to comment #3)
> Therefore stealing review and I'll land this as well so we can get a resonable
> build out for trunk at least. r+a=Standard8.

Thanks, Mark. I didn't realize that it would break things so badly, and I was swamped with 2.0rc1 work, that's why the review stalled for a bit.

Note You need to log in before you can comment on or make changes to this bug.