521041 - Make all translation foreign keys ON DELETE SET NULL and delete translations before removing data rows

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Code Quality, defect, P4)

Description

[Fred Wenzel [:wenzel]]

This is same thing as bug 513962, but for all other models.

The code to delete translations needs to go into the app_model beforeDelete() callback (we can gank that from the collections model), and we need to ensure that no models overwrite beforeDelete() without calling the parent.

Also, all translation foreign keys need to become ON DELETE SET NULL, because we deleting translations will otherwise throw a foreign key error.

Comment 1

[Wil Clouser [:clouserw]]

Moving this to 4.x make turn this into a wontfix but at least it gives a timeline to be done.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> Moving this to 4.x make turn this into a wontfix but at least it gives a
> timeline to be done.

what?

Comment 3

[Fred Wenzel [:wenzel]]

s/make/may !

Comment 4

[Justin Scott [:fligtar]]

Does Zamboni handle this properly?

Comment 5

[Wil Clouser [:clouserw]]

jbalogh ran into this recently in another bug.  -> jeff to think about, but still not something we need to look at right away if we don't have time

Comment 6

[Rob Hudson [:robhudson]]

I ran into this recently too when working with the category localization page. I filed another bug which is related (or a dupe)...

https://bugzilla.mozilla.org/show_bug.cgi?id=720038

Comment 7

[Wil Clouser [:clouserw]]

Thanks for filing this.  In an effort to not drown in existing reports we're aggressively closing old enhancements and bugs to get the buglist to a reasonable level so we can scope and process bug sprints in an effective manner.

Patches for this bug are still welcome.