crash [@ nsNSSSocketInfo::EnsureDocShellDependentStuffKnown()]

RESOLVED WORKSFORME

Status

()

Core
Security: PSM
--
critical
RESOLVED WORKSFORME
9 years ago
6 years ago

People

(Reporter: wsmwk, Assigned: kaie)

Tracking

({crash})

Trunk
x86
All
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [psm-fatal], crash signature)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
crash nsNSSSocketInfo::EnsureDocShellDependentStuffKnown()
shortlived/gone but wanted to get this recorded in bugzilla.
mostly in 20090926 and 20090926 of SM, Fx, and TB.
Sounds like app update is the consumer of the code that is actually crashing and this will need to be fixed in networking. Do you have a crash report?
(Reporter)

Comment 2

9 years ago
Ammendment to comment 0 ... TB and SM were all 20090926 and 20090927 builds. FX's crashes build dates don't coincide : 2009082700, 2009082400, 2009072900, 2009042300, 2008052900 http://crash-stats.mozilla.com/report/list?query_search=signature&query_type=exact&query=nsNSSSocketInfo%3A%3AEnsureDocShellDependentStuffKnown%28%29&date=&range_value=4&range_unit=weeks&do_query=1&signature=nsNSSSocketInfo%3A%3AEnsureDocShellDependentStuffKnown%28%29

SM http://crash-stats.mozilla.com/report/index/a1d0469d-e998-4b16-8541-ba0eb2090926

Thunderbird bp-e55131f2-40bf-4539-ac16-f85742090928
0	thunderbird.exe	nsNSSSocketInfo::EnsureDocShellDependentStuffKnown	 security/manager/ssl/src/nsNSSIOLayer.cpp:393
1	thunderbird.exe	nsNSSSocketInfo::GetPreviousCert	security/manager/ssl/src/nsNSSIOLayer.cpp:758
2	thunderbird.exe	HandshakeCallback	security/manager/ssl/src/nsNSSCallbacks.cpp:918
3	ssl3.dll	ssl3_HandleFinished	security/nss/lib/ssl/ssl3con.c:7859
4	ssl3.dll	ssl3_HandleHandshakeMessage	security/nss/lib/ssl/ssl3con.c:8015
5	ssl3.dll	ssl3_HandleHandshake	security/nss/lib/ssl/ssl3con.c:8083
6	ssl3.dll	ssl3_HandleRecord	security/nss/lib/ssl/ssl3con.c:8346
7	ssl3.dll	ssl3_GatherCompleteHandshake	security/nss/lib/ssl/ssl3gthr.c:206
8	ssl3.dll	ssl_GatherRecord1stHandshake	security/nss/lib/ssl/sslcon.c:1258
9	ssl3.dll	ssl_Do1stHandshake	security/nss/lib/ssl/sslsecur.c:151
10	ssl3.dll	ssl_SecureSend	security/nss/lib/ssl/sslsecur.c:1176
11	ssl3.dll	ssl_SecureWrite	security/nss/lib/ssl/sslsecur.c:1221
12	ssl3.dll	ssl_Write	security/nss/lib/ssl/sslsock.c:1488
13	thunderbird.exe	nsSSLThread::Run	security/manager/ssl/src/nsSSLThread.cpp:1045
Looks like it happened on startup as well per one of the report comments.

Moving to NSS
Assignee: nobody → nobody
Component: Application Update → Libraries
Product: Toolkit → NSS
QA Contact: application.update → libraries
Version: Trunk → trunk
Seems like a straightforward problem, no one is verifying the success of the GetProxyForObject call. Apparently jonath added this code in bug 423247. Over to PSM.
Assignee: nobody → kaie
Blocks: 423247
Component: Libraries → Security: PSM
Product: NSS → Core
QA Contact: libraries → psm
Version: trunk → Trunk

Comment 5

9 years ago
Created attachment 411690 [details] [diff] [review]
untested

so, afaict, the code johnath last touched leaks one variable among other things. this patch isn't tested (not even by a compiler), but it should do the right things.
Attachment #411690 - Flags: review?(johnath)
Comment on attachment 411690 [details] [diff] [review]
untested

I landed this code for bug 423247, but it was Kaie's patch. I'm not a PSM peer and don't have experience with this code - I certainly shouldn't review it. Moving your request to kaie; rrelyea and bz were the reviewers on that bug.
Attachment #411690 - Flags: review?(johnath) → review?(kaie)

Comment 7

9 years ago
Created attachment 413892 [details] [diff] [review]
untested
Attachment #411690 - Attachment is obsolete: true
Attachment #413892 - Flags: review?(kaie)
Attachment #411690 - Flags: review?(kaie)

Comment 8

9 years ago
Created attachment 413893 [details] [diff] [review]
untested

arg, qref is slow :(
Attachment #413892 - Attachment is obsolete: true
Attachment #413893 - Flags: review?(kaie)
Attachment #413892 - Flags: review?(kaie)
I actually crashed in a stack that seems a bit similar to this one - http://crash-stats.mozilla.com/report/index/bp-750e6e0a-c174-406a-93dc-a09702091223. It happened right after I updated my build to the latest nightly.
(Assignee)

Updated

8 years ago
Whiteboard: [psm-fatal]
This no longer appears to happen in Firefox 4 code (Gecko 2.0).  Closing, unless we want a branch fix for this.

http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=EnsureDocShellDependentStuffKnown&date=10%2F05%2F2010%2014%3A45%3A19&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsNSSSocketInfo%3A%3AEnsureDocShellDependentStuffKnown%28%29

http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=EnsureDocShellDependentStuffKnown&date=10%2F05%2F2010%2014%3A45%3A19&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsCOMPtr_base%3A%3A%7EnsCOMPtr_base%28%29%20%7C%20nsNSSSocketInfo%3A%3AEnsureDocShellDependentStuffKnown%28%29

http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=EnsureDocShellDependentStuffKnown&date=10%2F05%2F2010%2014%3A45%3A19&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsCOMPtr%3CnsILocaleService%3E%3A%3A%7EnsCOMPtr%3CnsILocaleService%3E%28%29%20%7C%20nsNSSSocketInfo%3A%3AEnsureDocShellDependentStuffKnown%28%29
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WORKSFORME
Crash Signature: [@ nsNSSSocketInfo::EnsureDocShellDependentStuffKnown()]
(Assignee)

Updated

6 years ago
Attachment #413893 - Flags: review?(kaie)
You need to log in before you can comment on or make changes to this bug.