521048 - create a IS_PLACE_URI sqlite function

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

> Sdwilsh (https://bugzilla.mozilla.org/show_bug.cgi?id=516940#c10):
> We do this in so many places, I feel like we should make a SQL function to
> detect place URI's in SQL:
> AND NOT PLACE_URI(h.url).  Can you file a follow-up please?

the problem is that we can optimize the TRUE case (using h.uri > "place:" AND
h.uri < "place;") but we can't optimize the FALSE case (it would be an OR, so
SUBSTR is faster)... since this follows two paths based on result it's hard to
generalize it into a sqlite function, unless we do something like
CHECK_PLACE_URI(true/false) that uses a different path based on input. btw i'll
file the followup.

Comment 1

[Marco Bonardo [:mak]]

the current methods are fine.