521120 - Search button that cuts off looks broken, and user unable to scroll thru the list

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Madhava Enros [:madhava]]

As shown here: http://www.flickr.com/photos/madhava_work/3990228651/

The last of the default bookmark set is cut off at the edge of the screen (and will only be more so when we get the larger search provider icons in).

One possible issue is that the button cuts off before the screen edge, making it look like the end is just missing, rather than being off-screen.

What would make the intended behavior even more clear, though, is to include an overlay at the end with an arrow on it, to indicate that panning to the right is something that can be done -- this was in the original mockups and, I think, in an earlier version of the awesomescreen styling.

I'll put together a mockup and attach it to the bug.

Comment 1

[Biju]

All we need is an ability to scroll right and left on the search plugin list. 
Just like the Firefox Tabbar right/left scroll buttons.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> All we need is an ability to scroll right and left on the search plugin list. 
> Just like the Firefox Tabbar right/left scroll buttons.

We can already pan left and right in the list. This bug is about the appearance.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: screenshot

I have a crazy idea - mainly because I dislike the idea of panning left/right to get the right search engine.

Why don't we get rid of the bottom panel on the awesome screen?
Yeah crazy!

Here the idea:
 * Users need the search engines only when they want to initiate a search, which means he search for something that they wrote into the awesome bar, so why not display the search engines as _additional_ results at the end of the search?

Benefits:
 * More space on the awesome screen
 * No more pan left/right, all the search engines can fit on the screen
 * Reduce the delay the first time we show the awesomescreen by creating the rows only once the user has start a search

Here a screenshot of a very dirty implementation of the idea.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Styles the autorepeat buttons in the autoscrollbox

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch is the same as the last but forces the arrows to create a padding,
even when the XBL tries to collapse them

Comment 6

[Madhava Enros [:madhava]]

Getting final images from sean.

Comment 7

[Sean Martell]

Attachment: Arrow Left - 16x24

Comment 8

[Sean Martell]

Attachment: Arrow Right - 16x24

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 407641 [details] [diff] [review]
patch 2

>diff --git a/themes/hildon/browser.css b/themes/hildon/browser.css

>+#autocomplete_navbuttons autorepeatbutton[disabled="true"] {
>+  visibility: hidden;

I understand the collapsed=true case, but why is this one needed? I couldn't find where the [disabled] implied a non-default visibility...

Kinda seems like whether the arrows get collapsed should be controllable with just an attribute on the scrollbox, but this is fine for now.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #9)

> >+#autocomplete_navbuttons autorepeatbutton[disabled="true"] {
> >+  visibility: hidden;
> 
> I understand the collapsed=true case, but why is this one needed? I couldn't
> find where the [disabled] implied a non-default visibility...

When the scrollbox has reached one of it's extremes, the arrow is shown in a disabled state, not surprising, but looked odd in our case, so I just made the arrow disappear.

Comment 11

[Sean Martell]

Attachment: All Arrows - 16x16

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

updated arrows and pushed:
https://hg.mozilla.org/mobile-browser/rev/d3b74551beb2

Comment 13

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre

Comment 14

[Al Billings [:abillings - ex-MoCo]]

Added to Litmus: https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9830