521143 - xpcshell-tests: test_autocomplete.js fails when 'strict' & 'werror' is on

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Jae-Seong Lee-Russo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091007 Minefield/3.7a1pre (.NET CLR 3.5.30729)

$ make SOLO_FILE="test_autocomplete.js" -C toolkit/components/satchel/test/ che
ck-one
make: Entering directory `/c/mozilla-build/mozilla-central/toolkit/components/sa
tchel/test'
c:/mozilla-build/python25/python2.5.exe -u /c/mozilla-build/mozilla-central/conf
ig/pythonpath.py \
          -I/c/mozilla-build/mozilla-central/build \
          /c/mozilla-build/mozilla-central/testing/xpcshell/runxpcshelltests.py
\
          --symbols-path=../../../../dist/crashreporter-symbols \
          --test-path=test_autocomplete.js \
          ../../../../dist/bin/xpcshell \
          ../../../../_tests/xpcshell/test_satchel/unit
TEST-UNEXPECTED-FAIL | c:\mozilla-build\mozilla-central\_tests\xpcshell\test_sat
chel\unit\test_autocomplete.js | test failed (with xpcshell return code: 0), see
 following log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | FAILED in test #0 -- TypeError: assi
gnment to undeclared variable timeGroupingSize

  <<<<<<<
INFO | Result summary:
INFO | Passed: 0
INFO | Failed: 1
make: *** [check-one] Error 1
make: Leaving directory `/c/mozilla-build/mozilla-central/toolkit/components/sat
chel/test'

Reproducible: Always

Steps to Reproduce:
1. Run the xpcshell test with the '-S' option
Actual Results:  
Failed

Expected Results:  
Passed

Comment 1

[Jae-Seong Lee-Russo]

Attachment: Fix 'assignment to undeclared variable'

Comment 2

[Jae-Seong Lee-Russo]

Attachment: Convert to UNIX newline

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/5cfc030d928d

Comment 4

[Nochum Sossonko [:Natch]]

Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1a4b504432ac

Is this really clear to land on 1.9.1? I.e., no approval necessary?

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

any patch landing on a stability branch needs approval, regardless the entity of the patch, so i'd say no, this is not clear to land on 1.9.1.

Comment 6

[Nochum Sossonko [:Natch]]

Clearing keyword then...

Comment 7

[Nochum Sossonko [:Natch]]

Comment on attachment 405441 [details] [diff] [review]
Convert to UNIX newline

Test-only change...

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 405441 [details] [diff] [review]
Convert to UNIX newline

Approved for 1.9.1.8, a=dveditz for release-drivers

Comment 9

[Daniel Veditz [:dveditz]]

Natch: can you do the check-in for 1.9.1 as well? Thanks.

Comment 10

[Nochum Sossonko [:Natch]]

Comment on attachment 405441 [details] [diff] [review]
Convert to UNIX newline

$ hg qpush
applying werror_ac
unable to find 'toolkit/components/satchel/test/unit/test_autocomplete.js' for p
atching
2 out of 2 hunks FAILED -- saving rejects to file toolkit/components/satchel/tes
t/unit/test_autocomplete.js.rej
patch failed, unable to continue (try -v)
toolkit\components\satchel\test\unit\test_autocomplete.js: The system cannot fin
d the file specified
toolkit/components/satchel/test/unit/test_autocomplete.js not tracked!
patch failed, rejects left in working dir
errors during apply, please fix and refresh werror_ac


Patch doesn't apply to 1.9.1