521172 - PluginCheck is broken on trunk

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://www-trunk.stage.mozilla.com/en-US/plugincheck/

https://www-trunk.stage.mozilla.com/img/tignish/plugincheck/ajax-loader.gif just keeps spinning.

Error: console is not defined
Source File: https://www-trunk.stage.mozilla.com/js/plugincheck.js
Line: 45

Error: checkPlugins is not defined
Source File: https://www-trunk.stage.mozilla.com/en-US/plugincheck/
Line: 185

JSON object is failing to load again, or something?

/me should learn how to use Firebug

Comment 1

[Michael Morgan [:morgamic]]

pfs2 seems to be non-responsive.

http://pfs2.stage.mozilla.com/

Comment 2

[Michael Morgan [:morgamic]]

This bug at least tells us that there should be a more graceful way to handle a failed connection to the PFS2 service.  Renaming.  I'll file a separate bug for the stage server being down.

Comment 3

[Michael Morgan [:morgamic]]

Bug 521180 filed for the stage server.

Comment 4

[Michael Morgan [:morgamic]]

Seems like any console logging should have a wrapper script that handles console existence every time instead of having to do if(window.console) every time?  Should probably break any console.error(), etc. calls out to something more generic to cut down on code.

Comment 5

[Michael Morgan [:morgamic]]

Changing back, it's definitely not pfs2 server.

Comment 6

[Michael Morgan [:morgamic]]

Until we figure it out I rolled back so trunk is back to r53007 (r53030).

Comment 7

[Austin King [:ozten]]

I need to work on the error haneling.

Yesterday afternoon we switched from jquery.ajax to appending a script tag manually. This changed the scope and error handeling mechanism. We can't use a try/catch or depend on jquery's error callback.

I'll add a window.onerror handler.

The reason we made the change is to get ride of jQuery's cache busting parameter, but we loose a lot of these freebies.

Comment 8

[Austin King [:ozten]]

(In reply to comment #4)
I will extract a method for these.

Comment 9

[Austin King [:ozten]]

I'm unable to identify what broke. Possibly a mis-match between html and javascript? I've pushed this code back out. Please verify stage is working.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- it's back up, thanks (scary that we don't know what broke it).

Comment 11

[Austin King [:ozten]]

I didn't mean to close this bug. I'm still working on the error handeling portion of making JSONP requests.

Comment 12

[Austin King [:ozten]]

In case of timeout or error communicating with the pfs2 server, the script will 
remove the plugin detection table and show an error panel.

http://skitch.com/oztenskitch/nn11x/plug-in-check

Clicking retry reloads the page.

Comment 13

[Austin King [:ozten]]

Adding jquery-jsonp library. Adding logic to retry 3 times. Hiding plugin table and displaying retry. Making sure no cache busting is done in the url.

Testing tips... We could check in a bad change to PFS.php or you could change your /etc/hosts file so that pfs2.stage.mozilla.com points to localhost

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #13)
> Adding jquery-jsonp library. Adding logic to retry 3 times. Hiding plugin table
> and displaying retry. Making sure no cache busting is done in the url.
> 
> Testing tips... We could check in a bad change to PFS.php or you could change
> your /etc/hosts file so that pfs2.stage.mozilla.com points to localhost

I didn't need to do all that; it's down right now, so it's easy to verify (I see "Plugin Finding Service Error

We've encountered an error. Please try your request again later." with a Retry button) :-(

Verified FIXED.