521209 - Alt-S and alt-D access key twice in Options/Display

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

The Tools->Options tab Display now includes Fonts. Here "_S_ize" was added, but size was already there for quoted plain text messages. As a result Alt-S access key doesn't work.

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

It's called Display Pane, tab is Formatting...

Comment 2

[Nikolay Shopik]

confirm
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20091007 Shredder/3.0pre

Comment 3

[Wayne Mery (:wsmwk)]

there's also two Ds

Comment 4

[:aceman]

I can do this. So what is the proposal?
Default _F_ont ? Second occurence of size -> Si_z_e ?

Also, shouldn't "Tags can be used to categorize and prioritize your messages." have an accesskey? It would focus the tag list.

Removing wanted-tb3 flag, it is outdated.

Comment 5

[Wayne Mery (:wsmwk)]

Attachment: options display accesskey

to me,what makes the most sense is something approximate to what is shown in the screen shot

Comment 6

[:aceman]

Bwinton, would you accept the proposal in the screenshot?

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Wayne, why do you want to change Style to _S_, instead of just leaving it as _y_, and letting the second Size keep the _S_?

Comment 8

[Wayne Mery (:wsmwk)]

Of all the options shown, I'd think the most used would be Font and Size at the top. SO thinking on it more, my original rationale for attachment 574164 [details] isn't convincing.  

How about making the second Size = _z_, keeping first Size as _S_?

Comment 9

[:aceman]

That is my comment 4 :)

Comment 10

[Blake Winton (:bwinton) (:☕️)]

Hmm, having f be the key for "Default font" would lead to "De_f_ault Font".  :(

Okay, so ui-r=me for keys in the following order (from top-left)
_D_efault Font, _S_ize,
Display _e_moticons as graphics,
St_y_le, Si_z_e

does that work for everyone?

Comment 11

[:aceman]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)
> Hmm, having f be the key for "Default font" would lead to "De_f_ault Font". 
Ah, yes.

> does that work for everyone?
No problem with me, I do not use the keys. I'll patch whatever you decide.

Comment 12

[Wayne Mery (:wsmwk)]

I propose dumping a can of alphabet soup and see what floats to the top :)

seriously though, I'm cool with comment 10

Comment 13

[:aceman]

Attachment: patch, changing accesskeys per comment 10

Comment 14

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 576980 [details] [diff] [review]
patch, changing accesskeys per comment 10

Review of attachment 576980 [details] [diff] [review]:
-----------------------------------------------------------------

WFM!

Comment 15

[:aceman]

Can you also give review?

Comment 16

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 576980 [details] [diff] [review]
patch, changing accesskeys per comment 10

Review of attachment 576980 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, fine, r=me, too.

Later,
Blake.

Comment 17

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/a52dab6b64f4