52124 - Using iframe inside of deck (or tabpanel) is broken (e.g. about.xul)

Status: VERIFIED FIXED

(Core :: XUL, defect, P4)

Description

[Avi Drissman]

To repro:

Go to the Preferences (assuming the window doesn't come up as blank... aaaargh!) and 
under "debug" select the about box to be a dialog. Say OK.

Now, select "about mozilla" (on the Mac, from the help menu, ala bug 43935).

Expected:

Two tabs. Clicking on a tab brings up the correct file/pane.

What you get:

Two tabs. No matter which one you select, both about files (the "about mozilla" and 
"contributors") are rendered at once. You see the contributors file, but if you scroll, the 
about mozilla file flashes briefly before being overpainted.

Mac build 2000090820.

Comment 1

[Chris Waterson]

sounds like a bug with tabs. to xptoolkit for triage.

Comment 2

[John Morrison]

'chrome://global/content/about.xul' is placing <iframe>s inside <tabpanel>s.
<tabpanel> is now XBL that derives from <xul:deck>. 

I'm not sure if this is supported. evaughan: is it?

If it is not supported, then about.xul needs to be changed for nsbeta3
(either the .xul is rewritten to not use <iframe>s, or to use them,
but not in a <tabpanel>, <deck> or <stack>). (Or it may be supported,
but broken: however, if this is not done anywhere else in the UI, then
it would still be better to just change about.xul at this point in the
game).

(By the way, this is XP win32/mac/linux, with variations in symptoms).

Comment 3

[John Morrison]

I spoke with Eric, and this is a regression: using <iframe> inside of 
<deck>/<tabpanel was working, but has been broken. 

Nom. nsbeta3, to reverse the regression. 

Note 1: if this cannot be fixed, then I will file a bug to change about.xul so 
that it can workaround this problem.

Note 2: about.xul is the only place that I found in the UI that is using 
<iframe> inside a <deck> or <tabpanel>. However, I may have missed cases
where either this is done via JS code, or where an XBL binding has been 
used to create a specialized form of <deck> or <tabpanel>

Comment 4

[John Morrison]

Updating summary from "About box rendering both panes at once".

Comment 5

[Peter Trudelle]

What is the difference in difficulty between the two? Could new such uses crop
up anytime?

Comment 6

[John Morrison]

I'm not sure which are the "two" in "between the two". If you mean between
changing about.xul, and fixing the regression, it would be fairly 
straightforward (if somewhat 'uglier') to have about.xul not use a <tabpanel> 
(e.g., use two iframes and switch src with a button, as in Profile Manager).
As for how much to fix the regression, Eric would have to say. 

Comment 7

[Peter Trudelle]

Yes, that is what I meant.  Changing about.xul could be wasted effort though, if
a need arises to fix the regression before we ship.

Comment 8

[Eric Vaughan]

Have a fix. Will check in when the build stops spontainously combusting.

Comment 9

[Peter Trudelle]

nsbeta3+ to checkin a fix, P4.

Comment 10

[Eric Vaughan]

Fixed

Comment 11

[Eric Vaughan]

fixed

Comment 12

[John Morrison]

verified fixed for about.xul, tabpanels and decks mac/linux/win32 2000091508
(Note: tabpanels are horked today under Classic skin so about.xul looks wrong with
 that skin, but that is a different bug).
(note to self http://jrgm.mcom.com/bugs/52124/test.xul).