521304 - Start Menu Flyout fails to refresh properly with jumplists and application icons

Status: RESOLVED DUPLICATE of bug 521141

(Firefox :: General, enhancement)

Description

[[not reading bugmail]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b1pre) Gecko/20091008 Namoroka/3.6b1pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b1pre) Gecko/20091008 Namoroka/3.6b1pre (.NET CLR 3.5.30729)

Since Windows 7 Jumplists support landed, which includes Recent, Pinned, Frequent and Task lists, we should also include the same support for the Windows 7 Start Menu Flyout feature for app parity.

Reproducible: Always

Actual Results:  
no support yet

Expected Results:  
Support start menu flyout feature in Windows 7.

See bug 473045 for jumplist support, and windows 7 meta bug 474052.

Comment 1

[Jim Mathies [:jimm]]

I believe this is a dupe of bug 518666, once you have jump list support enabled, the fly outs show up as soon as you pin fx to the start menu. trunk builds now support this.

Comment 2

[[not reading bugmail]]

I wasn't sure about that, I though they'd be one in the same too after it landed.  I guess maybe we need to support add the jumplist features to the flyout then (or patch the code). Trunk shows the flyout, but its not populating, all I see is Recent:Bookmarks on the flyout.  

I tried several scenarios to pin/unpin over and over again from the desktop and startmenu and taskbar icons and now I got two icons on the taskbar for Minefield again (both of which are pointing back to the default install folder/.exe).  

On the taskbar, the newly pinned icon is showing the jumplist the same as startmenu flyout list.  Recent:bookmarks.

The other taskbar icon which is currently running shows pinned list, tasks, frequent, etc.

Testing this, I think there is a bug with startmenu and taskbar points to the same firefox.exe but the startmenu icon doesn't know its the same as the taskbar icon running and allows you to pin a Minefield (2) which matches the start menu.

I can create a couple of screenshots if needed.

Comment 3

[Jim Mathies [:jimm]]

(In reply to comment #2)
> I wasn't sure about that, I though they'd be one in the same too after it
> landed.  I guess maybe we need to support add the jumplist features to the
> flyout then (or patch the code). Trunk shows the flyout, but its not
--> populating, all I see is Recent:Bookmarks on the flyout.  
> 
> I can create a couple of screenshots if needed.

Would you mind creating a shot of the population problem? I've confirmed the fly out and the jump list are the same, if we have one, we should have the other.

Comment 4

[[not reading bugmail]]

Attachment: Start Menu Flyout Empty; no jumplist features exist on it.

Flyout exists (this one shows Recent: bookmarks, I removed it from the list, now the flyout doesn't flyout)  Bookmarks was export of my firefox bookmarks file which I must have opened in Minefield once, but I don't remember when.

Comment 5

[[not reading bugmail]]

Attachment: Start Menu Flyout matching second Icon in taskbar with empty jumplist

Comment 6

[[not reading bugmail]]

Attachment: Running Minefield Showing jumplist setup and taskbar prefs.

This also shows doubled tooltips which are another bug probably.

Comment 7

[Jim Mathies [:jimm]]

(In reply to comment #6)
> Created an attachment (id=405348) [details]
> Running Minefield Showing jumplist setup and taskbar prefs.
> 
> This also shows doubled tooltips which are another bug probably.

(In reply to comment #5)
> Created an attachment (id=405347) [details]
> Start Menu Flyout matching second Icon in taskbar with empty jumplist

So I'm confused here, The first is correct and what you should expect. The second, I'm not really sure how that got there since there are no task listings.

It looks like you have multiple shortcuts pinned, can you unpin all of them, right click on the main window, pin that, and see what its shortcut has?

Comment 8

[[not reading bugmail]]

It is a little confusing over XP/Vista.  Its just as hard to explain, and I don't have a video for show and tell.  I'll do my best and I may say the same thing twice so bare with me, so I hope it just makes sense.

Found another bug with the trunk in this issue.. bug 521141 really exists on Minefield.  The latest Namoroka nightly (without the new registration bug 520937 gets added) knows its pinned state to the taskbar from all other icons on the system, but Minefield does not know they are all the same.  The pinned states are not synced on Minefield hourly from earlier today, only the Latest Branch Nightly.  (I even un-installed Minefield and tried to delete registry keys to double check)

(In reply to comment #7)
> I'm not really sure how that got there since there are no task
> listings.

> It looks like you have multiple shortcuts pinned, can you unpin all of them,
> right click on the main window, pin that, and see what its shortcut has?

Yeah, the newly pinned item from off the start menu feels like a shortcut or bug 521141 must still exist; It acts like another app and doesn't inherit the jumplist, but it just starts another window instance if you click on Minefield instead, which then inherits the jumplist, but this icon.  I cannot even test Branch jumplists yet for Flyout sync.

So because they are out of sync, Minefield creates a second icon from pinning from anywhere else but off the running program icon and creates the second icon everytime.  The newly created icon and can be added before or after pinning Minefield to the taskbar.

Summary: Minefields' Flyout does not inherit the running taskbar jumplist nor do all other icons on the system for Minefield inherit the pinned state from the taskbar pinned state.  (Latest nightly Namoroka doesn't have this problem)

I have FF, Minefield pinned and Nomoroka pinned, and the pin from elsewhere (which can be pinned/unpinned and have a pinned state independently of the running taskbar icon's pinned state. Nomoroka can be pinned/unpinned from anywhere all the same.  This issue feels like bug 521141.

And all this, just to see if the Flyout should be inheriting the jumplists, or be implemented on the Flyout ;)

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #8)
> Found another bug with the trunk in this issue.. bug 521141 really exists on
> Minefield.  The latest Namoroka nightly (without the new registration bug
> 520937 gets added) knows its pinned state to the taskbar from all other icons
> on the system, but Minefield does not know they are all the same.  The pinned
> states are not synced on Minefield hourly from earlier today, only the Latest
> Branch Nightly.  (I even un-installed Minefield and tried to delete registry
> keys to double check)


Namoroka and Minefield are two different apps as far as the taskbar is concerned. They shouldn't share jump lists, nor should they share pinned icons. 

Namoroka currently does not support jump lists, so you should not see a jump list on it's application icon. Minefield on the other hand registers with the taskbar and generates lists.


> 
> (In reply to comment #7)
> > I'm not really sure how that got there since there are no task
> > listings.
> 
> > It looks like you have multiple shortcuts pinned, can you unpin all of them,
> > right click on the main window, pin that, and see what its shortcut has?
> 
> Yeah, the newly pinned item from off the start menu feels like a shortcut or
> bug 521141 must still exist; It acts like another app and doesn't inherit the
> jumplist, but it just starts another window instance if you click on Minefield
> instead, which then inherits the jumplist, but this icon.  I cannot even test
> Branch jumplists yet for Flyout sync.


Bug 521141 - Start menu / programs shortcuts pinned to the taskbar don't group correctly.


> 
> So because they are out of sync, Minefield creates a second icon from pinning
> from anywhere else but off the running program icon and creates the second icon
> everytime.  The newly created icon and can be added before or after pinning
> Minefield to the taskbar.
> 
> Summary: Minefields' Flyout does not inherit the running taskbar jumplist nor
> do all other icons on the system for Minefield inherit the pinned state from
> the taskbar pinned state.  (Latest nightly Namoroka doesn't have this problem)
> 
> I have FF, Minefield pinned and Nomoroka pinned, and the pin from elsewhere
> (which can be pinned/unpinned and have a pinned state independently of the
> running taskbar icon's pinned state. Nomoroka can be pinned/unpinned from
> anywhere all the same.  This issue feels like bug 521141.
> 
> And all this, just to see if the Flyout should be inheriting the jumplists, or
> be implemented on the Flyout ;)


With these caveats and the current issues with pinned start menu items maybe you can sort this down a bit. I'd suggest ignoring Namoroka behavior for now and simply concentrating on Minefield.

Comment 10

[[not reading bugmail]]

I did see Flyout's finally and they matched the jumplist on Minefield after I restarted Windows 7 at one point, but now its not there again after I deleted the folder and tried to reinstall.  So now trying to hunt down STR.

Comment 11

[[not reading bugmail]]

Ok, Jim.. I got some STR for Minefield.  Flyouts do exist and are same as the jumplists, pinned, recent, and task items, (tasks only show when browser is running like the jumplist).

Basically, Installing builds wipe out the flyout from a pinned start menu icon.
Unpin the startmenu icon and always use the recently used list icon to repin Minefield to start menu (all other icons do not work and produce results like bug 521141), then Restart Windows 7 and the Flyout should show up or come back.


Items affecting Flyouts/Jumplist from working:

-Having to restart Windows 7
-"Recent Items" turned on/off (default is checked) in Start Menu Preference panel
-Browser.taskbar preferences setting in Minefield about:config
-Start Menu properties "Recent Programs to display" (default = 10)
-Start Menu properties "Recent Number of jumplist items to display" (default = 10)
-Pinning from specific Minefield Icons (Bug 521141)
-Updating a partial nightly or installing hourly build wipes out flyouts
-Spawning Minefield taskbar Icons (Bug 521141)
-Opening external files don't seem to update the recent jumplist section (only showed up if you opened files before the jumplists landed on builds).
-Unpinning from the start menu and repinning to start menu

STR on any Minefield build since about 10/08:

-Turn on Start Menu Properties-Recent items checkbox
-Run Minefield, Install Partial Nightly build, Restart, or Install Hourly build.
-Unpin everything for Minefield on startmenu and taskbar
-Run Minefield from any icon
-Make sure about:config browser.taskbar preferences are enabled
-pin the taskbar icon to the taskbar
-go to start menu, recently used program icon should now be there
-right click recently used Minefield icon
-select pin to start menu, MInefield should be in the start menu pinned items which should now show above the recent programs
-Restart windows 7
-Flyout shows up for the pinned start menu icon, but doesn't on the recently listed start menu icon. 
-Run Minefield
-Change browser.taskbar preferences, they should dynamically update the jumplist and flyout

Try this next..

-Unpin minefield Start Menu icon, repin from recent programs list, flyout doesn't show up
-Restart Windows 7, it comes back
-uncheck recent items, flyout doesn't show up
-recheck recent items, flyout doesn't show up
-Restart Windows 7, Flyout should be back if you have repinned minefield from recent programs list

Hope that helps!

Comment 12

[Jim Jeffery not reading bug-mail 1/2/11]

I'm setting this to new, I cannot get the fly-out to appear even after several restarts and following the STR posted above.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091014 Minefield/3.7a1pre Firefox/3.7 (.NET CLR 3.5.30729) ID:20091014045102

Comment 13

[Jim Mathies [:jimm]]

(In reply to comment #12)
> I'm setting this to new, I cannot get the fly-out to appear even after several
> restarts and following the STR posted above.
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091014
> Minefield/3.7a1pre Firefox/3.7 (.NET CLR 3.5.30729) ID:20091014045102

Ignore the shortcuts the installer creates (even delete them to prevent confusion right after a fresh install). Run minefield, pin it to the taskbar, click the start menu, and type mine in the search bar. You should get a couple icons for minefield. Right click on the main link (not the safemode one) and select pin to start menu. (The same icon should have "unpin from taskbar" in it's options list.)

The two links our installer creates are not linked up yet. You can test what you've got by right-clicking after pinning minefield to the taskbar. If the option list doesn't have the unpin option, you know you have a shortcut that isn't synced up. (I usually delete those when I find them.)

Comment 14

[Jim Mathies [:jimm]]

(In reply to comment #11)

> Items affecting Flyouts/Jumplist from working:
> 
> -Having to restart Windows 7
> -"Recent Items" turned on/off (default is checked) in Start Menu Preference
> panel

Recent items was unchecked by default in the RC. This setting also shouldn't effect our jump list.

> -Browser.taskbar preferences setting in Minefield about:config
> -Start Menu properties "Recent Programs to display" (default = 10)
> -Start Menu properties "Recent Number of jumplist items to display" (default =
> 10)
> -Pinning from specific Minefield Icons (Bug 521141)
> -Spawning Minefield taskbar Icons (Bug 521141)

> -Updating a partial nightly or installing hourly build wipes out flyouts

Build version issue, something I will sort out. If the long version of Fx changes, the taskbar gets reset. I'm going to be making this less fine grained than it currently is.

> -Opening external files don't seem to update the recent jumplist section (only
> showed up if you opened files before the jumplists landed on builds).

What do you mean by "external files"? Web sites opened in the browser will effect what's listed in the jump list. [Refresh times: on open, on close, and while the browser is running, every 2 minutes.]

> -Unpinning from the start menu and repinning to start menu

This is working fine for me. The jump list remains. Can you confirm?

> 
> STR on any Minefield build since about 10/08:
> 
> -Turn on Start Menu Properties-Recent items checkbox
> -Run Minefield, Install Partial Nightly build, Restart, or Install Hourly
> build.
> -Unpin everything for Minefield on startmenu and taskbar
> -Run Minefield from any icon
> -Make sure about:config browser.taskbar preferences are enabled
> -pin the taskbar icon to the taskbar
> -go to start menu, recently used program icon should now be there
> -right click recently used Minefield icon
> -select pin to start menu, MInefield should be in the start menu pinned items
> which should now show above the recent programs
> -Restart windows 7
> -Flyout shows up for the pinned start menu icon, but doesn't on the recently
> listed start menu icon. 
> -Run Minefield
> -Change browser.taskbar preferences, they should dynamically update the
> jumplist and flyout
> 
> Try this next..
> 
> -Unpin minefield Start Menu icon, repin from recent programs list, flyout
> doesn't show up

Could not reproduce this in last night's nightly.

> -Restart Windows 7, it comes back
> -uncheck recent items, flyout doesn't show up
> -recheck recent items, flyout doesn't show up

Changing this start menu pref for me doesn't have any effect on a pinned link in the start menu with a jump list. Maybe there's some step I'm missing?

> Hope that helps!

Thanks for the detailed testing Dale, much appreciated.

Comment 15

[[not reading bugmail]]

Running Win7 RC 32bit - with some Performance settings turned off/a few still on.  (Mostly since my display is hard to read with everything on.)

I'm not sure what the deal is.  So far here is what I figured out on my machine.

Recent Items is default off, doesn't affect flyout.
Jumplists are affected by Privacy checkboxes on the first properties window pane of the Start Menu.
Recently Opened programs: Recently used list. 
External files: meaning I opened I:\bookmarks.html in Firefox or Minefield at one point and it showed up on the list, though, maybe If can clear the list of items, Windows doesn't re-display them in the future. 

I had started with build 10/10 and updated to 10/15 or 10/16 via partial.  So as noted the flyout for me seems to

Comment 16

[[not reading bugmail]]

[Crap: (hit the commit button accidentally!)  -- so to continue what I was saying.. and turned off a lot of the animations] be affected by me going into the Start Menu Properties pane going into the customize Pane:

>> Recent Items
> Changing this start menu pref for me doesn't have any effect on a pinned link
> in the start menu with a jump list. Maybe there's some step I'm missing?

No, I guess not, I didn't notice this, but my system, I didn't have to change anything.  I just clicked ok, clicked ok out of the dialog box and I find my Minefield flyout is gone, but comes back on a restart of Windows 7.

> Jumplists are affected by Privacy checkboxes on the first properties window
> pane of the Start Menu.

I was trying to read the Windows 7 help on Jump lists and was making notes here.. some of the checkboxes pertain to the jump list being displayed.

>> -Unpinning from the start menu and repinning to start menu
>>
>This is working fine for me. The jump list remains. Can you confirm?

I cannot seem to get this to work ever.  Only restarting Windows 7 does it for me.  What type of build are you running?

Comment 17

[[not reading bugmail]]

Ok, I found 2 corrections.  

1) If I enter Start Menu Properties Box and click ok to close, my Flyout disappears.  

2) If I log off, don't have to restart, my flyout comes back

Also, I'm logged on as myself as an Administrator account, but probably not logged on as admin per se and I'm using default install Minefield directory.

Comment 18

[[not reading bugmail]]

(In reply to comment #13)
> (In reply to comment #12)
> > I'm setting this to new, I cannot get the fly-out to appear even after several
> > restarts and following the STR posted above.
> > 
> > Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091014
> > Minefield/3.7a1pre Firefox/3.7 (.NET CLR 3.5.30729) ID:20091014045102
> 
> Ignore the shortcuts the installer creates (even delete them to prevent
> confusion right after a fresh install). 

Non of the icons anywhere in the start menu or desktop allow flyouts to stick, I tried this, deleting all shortcuts, but I still find start menu loves them.

> Run minefield, pin it to the taskbar,

Did that, then tried to pin the recently opened program icon to the start menu.
This is where my STR changed from yours here.. 

> click the start menu, and type mine in the search bar. You should get a couple
> icons for minefield. Right click on the main link (not the safemode one) and
> select pin to start menu. (The same icon should have "unpin from taskbar" in
> it's options list.)
> 

I cannot believe I missed this..  This worked on yesterday's builds and partial and hourly from later today.  I did do search results in prior builds, but I didn't check this codepath.

Right clicking on the *Search results Minefield icon and Minefield (safemode) and pin those to start menu and pin to taskbar..  then my flyouts stick for the start menu Pinned location.  They remain between build installs/partials/properties panel as a start Menu pinned item.

> The two links our installer creates are not linked up yet. You can test what
> you've got by right-clicking after pinning minefield to the taskbar. If the
> option list doesn't have the unpin option, you know you have a shortcut that
> isn't synced up. (I usually delete those when I find them.)

I didn't notice any shortcuts that didn't allow me to pin/unpin them to the start menu or taskbar, but anything that shows up in the recently opened programs doesn't have a flyout, and doesn't stick between build updates.  

Now, I'm not sure why I cannot get Minefield to show in Recently opened (used) programs list.. Since my Start Menu Properties are set to default.

Do you see the Minefield icon on the recently opened list here and with a flyout?

Comment 19

[[not reading bugmail]]

Attachment: Hourly build install, Start Menu Flyout Pinned from search result, and Recently Opened Icon Shows No Unpin and No Flyout; bad Unlinked icon

When I ran into bug 521141 I kept seeing the odd pin vs unpin icon being in sync or not.  The order makes a difference here as I think you mentioned your STR is the closest to reproducing good behavior, where mine is reproducing bad behavior.

First installing an hourly, then running minefield, pin to taskbar from taskbar icon, go to search bar, find "mine", right click I should see "unpin from taskbar" and "pin to start menu" as options.  Pin to start menu, flyout shows up and it sticks.

Also, once it works, I cannot unpin and expect pin to start menu to work from any icon, but I have to go back to the STR to invoke finding the taskbar pinned version in the search bar results to repin to the start menu.

If you bypass one of these steps, it doesn't work and I run into all the flyout disappearing acts from before, bad pinning behavior with recently opened items (see screenshot for bad icon).  And if I start by pinning Minefield to the start menu item first then run that and pin that taskbar I can produce spawning icons bug 521141 on the taskbar.

Comment 20

[Jim Jeffery not reading bug-mail 1/2/11]

Requesting blocking as the flyouts still are missing from the Start Menu Pinned item. 

Using today's nightly build.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100308 Minefield/3.7a3pre Firefox/3.6 ID:20100308055604