Last Comment Bug 521384 - Cannot set font size to 8 from Options-->tab Display (but Advanced window work)
: Cannot set font size to 8 from Options-->tab Display (but Advanced window work)
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 20.0
Assigned To: Javi Rueda
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-08 23:53 PDT by [:Aureliano Buendía]
Modified: 2012-12-16 16:05 PST (History)
5 users (show)
euryalus.0: wanted‑thunderbird3?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
screenshot (55.93 KB, image/jpeg)
2009-10-08 23:57 PDT, [:Aureliano Buendía]
no flags Details
patch deleting the "8" font size in advanced window (2.07 KB, patch)
2012-12-10 14:30 PST, Javi Rueda
mconley: review+
Details | Diff | Review

Description [:Aureliano Buendía] 2009-10-08 23:53:53 PDT
STR:

1. menu-->tools-->options... tab Display, buttonf Advanced;
2. set font as in attached screenshot (I think that the font name is irrilevant);
3. close Advanced window and return to Options window: I cannot set font size to 8 and font size not is show

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091008 Lightning/1.0pre Shredder/3.0pre ID:20091008033625
Comment 1 [:Aureliano Buendía] 2009-10-08 23:57:36 PDT
Created attachment 405419 [details]
screenshot
Comment 2 [:Aureliano Buendía] 2009-10-11 03:04:59 PDT
...maybe TB suppose always a minum font size not < 9?
Comment 3 Nikolay Shopik 2009-10-23 05:09:14 PDT
Same on trunk, btw.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091020 Shredder/3.1a1pre
Comment 4 Javi Rueda 2012-11-27 17:15:47 PST
The list items on Display tab were added with http://mxr.mozilla.org/comm-central/source/mail/components/preferences/display.xul?rev=1d88547281a4#109

Values for the list items on the font chooser have been always like that since the first merge.

I will ask about :bwinton this via IRC.
Comment 5 Javi Rueda 2012-12-04 11:04:18 PST
I have just contacted by IRC :bwinton and I was told that it will be ok to make both menu lists with a minimum value of 9.

Lines involved that should be changed -AFAIK and at first sight- are http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.xul#127 and http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.xul#187.

I am on another bug right now. If this one remains available when I become freed from that one, I could take it myself.
Comment 6 Javi Rueda 2012-12-10 14:30:07 PST
Created attachment 690571 [details] [diff] [review]
patch deleting the "8" font size in advanced window

Last reviewer of fonts.xul file was Mike. If :bwinton is a better try for this, please forward to him.
Comment 7 Mike Conley (:mconley) - (Needinfo me!) 2012-12-13 19:44:14 PST
Comment on attachment 690571 [details] [diff] [review]
patch deleting the "8" font size in advanced window

Looks good to me. Thanks for the patch!
Comment 8 Javi Rueda 2012-12-14 10:16:44 PST
Thank you for the review, Mike :-)
Comment 9 Mike Conley (:mconley) - (Needinfo me!) 2012-12-14 10:17:11 PST
(In reply to Javi Rueda from comment #8)
> Thank you for the review, Mike :-)

\o/
Comment 10 Ryan VanderMeulen [:RyanVM] 2012-12-16 16:05:43 PST
https://hg.mozilla.org/comm-central/rev/79a73f336716

Note You need to log in before you can comment on or make changes to this bug.