Closed
Bug 521384
Opened 15 years ago
Closed 11 years ago
Cannot set font size to 8 from Options-->tab Display (but Advanced window work)
Categories
(Thunderbird :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 20.0
People
(Reporter: Aureliano, Assigned: javirid)
Details
Attachments
(2 files)
55.93 KB,
image/jpeg
|
Details | |
2.07 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
STR: 1. menu-->tools-->options... tab Display, buttonf Advanced; 2. set font as in attached screenshot (I think that the font name is irrilevant); 3. close Advanced window and return to Options window: I cannot set font size to 8 and font size not is show Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091008 Lightning/1.0pre Shredder/3.0pre ID:20091008033625
Reporter | ||
Comment 1•15 years ago
|
||
Reporter | ||
Comment 2•15 years ago
|
||
...maybe TB suppose always a minum font size not < 9?
Flags: wanted-thunderbird3?
Comment 3•15 years ago
|
||
Same on trunk, btw. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091020 Shredder/3.1a1pre
Assignee | ||
Updated•12 years ago
|
OS: Windows XP → All
Version: 3.0 → Trunk
Assignee | ||
Comment 4•12 years ago
|
||
The list items on Display tab were added with http://mxr.mozilla.org/comm-central/source/mail/components/preferences/display.xul?rev=1d88547281a4#109 Values for the list items on the font chooser have been always like that since the first merge. I will ask about :bwinton this via IRC.
Assignee | ||
Comment 5•11 years ago
|
||
I have just contacted by IRC :bwinton and I was told that it will be ok to make both menu lists with a minimum value of 9. Lines involved that should be changed -AFAIK and at first sight- are http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.xul#127 and http://mxr.mozilla.org/comm-central/source/mail/components/preferences/fonts.xul#187. I am on another bug right now. If this one remains available when I become freed from that one, I could take it myself.
Assignee | ||
Comment 6•11 years ago
|
||
Last reviewer of fonts.xul file was Mike. If :bwinton is a better try for this, please forward to him.
Assignee: nobody → leofigueres
Attachment #690571 -
Flags: review?(mconley)
Comment 7•11 years ago
|
||
Comment on attachment 690571 [details] [diff] [review] patch deleting the "8" font size in advanced window Looks good to me. Thanks for the patch!
Attachment #690571 -
Flags: review?(mconley) → review+
Comment 9•11 years ago
|
||
(In reply to Javi Rueda from comment #8) > Thank you for the review, Mike :-) \o/
Comment 10•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/79a73f336716
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
You need to log in
before you can comment on or make changes to this bug.
Description
•